content/renderer/render_frame_impl.cc - Issue 2152353002: Remove DCHECK(!source_url.is_empty()) from RenderFrameImpl::decidePolicyForNavigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2152353002: Remove DCHECK(!source_url.is_empty()) from RenderFrameImpl::decidePolicyForNavigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index 0fe03c647e108e470c63b818949ba1f795a02eed..9ca4ebab8c220849b74f3755170559ea6334a3bd 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -4984,7 +4984,6 @@ WebNavigationPolicy RenderFrameImpl::decidePolicyForNavigation(

GURL source_url(old_url);

if (is_initial_navigation && source_url.is_empty() && frame_->opener())

source_url = frame_->opener()->top()->document().url();

- DCHECK(!source_url.is_empty());

should_fork = !source_url.SchemeIs(url::kFileScheme);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »