Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1230)

Issue 2152353002: Remove DCHECK(!source_url.is_empty()) from RenderFrameImpl::decidePolicyForNavigation (Closed)

Created:
4 years, 5 months ago by Tom Sepez
Modified:
4 years, 5 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, darin-cc_chromium.org, Ɓukasz Anforowicz, alexmos
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DCHECK(!source_url.is_empty()) from RenderFrameImpl::decidePolicyForNavigation BUG=622509 Committed: https://crrev.com/77b02a9e18d0a359c570e871d970fc515d54a9aa Cr-Commit-Position: refs/heads/master@{#405877}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M content/renderer/render_frame_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Tom Sepez
Charlie, second attempt to land this. Keep the logic the same to avoid breaking tests.
4 years, 5 months ago (2016-07-15 20:10:44 UTC) #2
Charlie Reis
Ok. The same POST bug is possible if a file page clears its opener, of ...
4 years, 5 months ago (2016-07-15 20:20:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2152353002/1
4 years, 5 months ago (2016-07-15 20:22:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 22:21:28 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 22:21:36 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 22:23:21 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77b02a9e18d0a359c570e871d970fc515d54a9aa
Cr-Commit-Position: refs/heads/master@{#405877}

Powered by Google App Engine
This is Rietveld 408576698