Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2152333002:
Fix the Win64 GN installer config (Closed)
|
Created:
4 years, 5 months ago by Sébastien Marchand Modified:
4 years, 5 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix the Win64 GN installer config
- Add the copy_first_run target (equivalent of https://cs.chromium.org/chromium/src/chrome/chrome_exe.gypi?q=%22First+run%22&sq=package:chromium&dr=C&l=462)
- Remove courgette.exe from the official Win64 archives as we're using courgette64.exe
BUG=628056
Committed: https://crrev.com/f2a3e3abd589b619860f8a2ac181e78ca91bd1ec
Cr-Commit-Position: refs/heads/master@{#406173}
Patch Set 1 #Patch Set 2 : Copy courgette64.exe to courgette.exe. #
Messages
Total messages: 25 (15 generated)
Description was changed from ========== Fix the Win64 GN installer config BUG=628056 ========== to ========== Fix the Win64 GN installer config - Add the copy_first_run target (equivalent of https://cs.chromium.org/chromium/src/chrome/chrome_exe.gypi?q=%22First+run%22...) - Remove courgette.exe from the official Win64 archives as we're using courgette64.exe BUG=628056 ==========
sebmarchand@chromium.org changed reviewers: + dpranke@chromium.org, mmoss@chromium.org
The CQ bit was checked by sebmarchand@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
PTAL.
lgtm
The CQ bit was checked by sebmarchand@chromium.org to run a CQ dry run
lgtm
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
brettw@chromium.org changed reviewers: + brettw@chromium.org
lgtm
The CQ bit was unchecked by dpranke@chromium.org
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix the Win64 GN installer config - Add the copy_first_run target (equivalent of https://cs.chromium.org/chromium/src/chrome/chrome_exe.gypi?q=%22First+run%22...) - Remove courgette.exe from the official Win64 archives as we're using courgette64.exe BUG=628056 ========== to ========== Fix the Win64 GN installer config - Add the copy_first_run target (equivalent of https://cs.chromium.org/chromium/src/chrome/chrome_exe.gypi?q=%22First+run%22...) - Remove courgette.exe from the official Win64 archives as we're using courgette64.exe BUG=628056 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Fix the Win64 GN installer config - Add the copy_first_run target (equivalent of https://cs.chromium.org/chromium/src/chrome/chrome_exe.gypi?q=%22First+run%22...) - Remove courgette.exe from the official Win64 archives as we're using courgette64.exe BUG=628056 ========== to ========== Fix the Win64 GN installer config - Add the copy_first_run target (equivalent of https://cs.chromium.org/chromium/src/chrome/chrome_exe.gypi?q=%22First+run%22...) - Remove courgette.exe from the official Win64 archives as we're using courgette64.exe BUG=628056 Committed: https://crrev.com/f2a3e3abd589b619860f8a2ac181e78ca91bd1ec Cr-Commit-Position: refs/heads/master@{#406173} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/f2a3e3abd589b619860f8a2ac181e78ca91bd1ec Cr-Commit-Position: refs/heads/master@{#406173} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
