Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 215233002: Update ui/display to use primitive types as defined in stdint.h (Closed)

Created:
6 years, 9 months ago by dnicoara
Modified:
6 years, 9 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Update ui/display to use primitive types as defined in stdint.h As instructed in base/basictypes.h we should use (u)int{8,16,32,64}_t rather than the ones without the '_t' suffix. BUG=333413 R=derat@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260118

Patch Set 1 #

Patch Set 2 : . #

Total comments: 4

Patch Set 3 : . #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -69 lines) Patch
M ui/display/chromeos/native_display_delegate.h View 2 chunks +3 lines, -1 line 0 comments Download
M ui/display/chromeos/output_configurator.h View 5 chunks +10 lines, -9 lines 0 comments Download
M ui/display/chromeos/output_configurator.cc View 1 2 7 chunks +7 lines, -7 lines 0 comments Download
M ui/display/chromeos/output_configurator_unittest.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M ui/display/chromeos/x11/native_display_delegate_x11.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/display/chromeos/x11/native_display_delegate_x11.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/display/edid_parser.h View 2 chunks +8 lines, -7 lines 0 comments Download
M ui/display/edid_parser.cc View 5 chunks +14 lines, -14 lines 0 comments Download
M ui/display/edid_parser_unittest.cc View 6 chunks +13 lines, -13 lines 0 comments Download
M ui/display/x11/edid_parser_x11.h View 2 chunks +4 lines, -3 lines 0 comments Download
M ui/display/x11/edid_parser_x11.cc View 4 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dnicoara
PTAL
6 years, 9 months ago (2014-03-27 19:22:48 UTC) #1
Daniel Erat
lgtm https://codereview.chromium.org/215233002/diff/20001/ui/display/chromeos/output_configurator.cc File ui/display/chromeos/output_configurator.cc (right): https://codereview.chromium.org/215233002/diff/20001/ui/display/chromeos/output_configurator.cc#newcode26 ui/display/chromeos/output_configurator.cc:26: const int64_t kConfigureDelayMs = 500; nit: just make ...
6 years, 9 months ago (2014-03-27 20:33:07 UTC) #2
dnicoara
https://codereview.chromium.org/215233002/diff/20001/ui/display/chromeos/output_configurator.cc File ui/display/chromeos/output_configurator.cc (right): https://codereview.chromium.org/215233002/diff/20001/ui/display/chromeos/output_configurator.cc#newcode26 ui/display/chromeos/output_configurator.cc:26: const int64_t kConfigureDelayMs = 500; On 2014/03/27 20:33:07, Daniel ...
6 years, 9 months ago (2014-03-27 21:12:21 UTC) #3
dnicoara
The CQ bit was checked by dnicoara@chromium.org
6 years, 9 months ago (2014-03-27 21:12:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/215233002/40001
6 years, 9 months ago (2014-03-27 21:17:48 UTC) #5
dnicoara
The CQ bit was unchecked by dnicoara@chromium.org
6 years, 9 months ago (2014-03-28 13:41:14 UTC) #6
dnicoara
6 years, 9 months ago (2014-03-28 13:46:23 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 manually as r260118 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698