Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2152323002: Remove Comparable interface from UrlInfo (Closed)

Created:
4 years, 5 months ago by cco3
Modified:
4 years, 5 months ago
Reviewers:
gone, mattreynolds
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Comparable interface from UrlInfo There are different ways we compare the UrlInfo class. There is no reason for it to be comparable instead of just using a custom Comparator each time as needed (as we already do). BUG=628711 Committed: https://crrev.com/bfb5deec916198eed2b2edf2621fb7142116faa8 Cr-Commit-Position: refs/heads/master@{#405875}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -63 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlInfo.java View 2 chunks +1 line, -62 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlInfoTest.java View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
cco3
4 years, 5 months ago (2016-07-15 18:57:50 UTC) #2
gone
This addresses a couple of them, but there's still one Lint warning in UrlManager: org/chromium/chrome/browser/physicalweb/UrlInfo.class ...
4 years, 5 months ago (2016-07-15 21:13:47 UTC) #3
gone
(lgtm for this one though)
4 years, 5 months ago (2016-07-15 21:14:25 UTC) #4
cco3
On 2016/07/15 21:13:47, dfalcantara wrote: > This addresses a couple of them, but there's still ...
4 years, 5 months ago (2016-07-15 21:24:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2152323002/1
4 years, 5 months ago (2016-07-15 21:24:59 UTC) #7
mattreynolds
lgtm
4 years, 5 months ago (2016-07-15 21:25:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 22:09:07 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 22:10:36 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bfb5deec916198eed2b2edf2621fb7142116faa8
Cr-Commit-Position: refs/heads/master@{#405875}

Powered by Google App Engine
This is Rietveld 408576698