DevTools: preserve computed properties expansion on Computed Style re-rendering

DevTools: preserve computed properties expansion on Computed Style re-rendering

Today, when the computed styles widget gets updated, it collapses all the
previously expanded properties.

This patch preserves property expansion on computed style re-rendering.

BUG=623317
R=dgozman

Committed: https://crrev.com/cd1ef8eab1d95051b259d196133ae35d1d0ee4da
Cr-Commit-Position: refs/heads/master@{#405929}

[lushnikov, 2016-07-15 18:50:45]

please, take a look

[lushnikov, 2016-07-15 18:50:51]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 18:51:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 20:55:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 20:55:40]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-07-16 01:14:56]

lgtm

https://codereview.chromium.org/2152313002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js
(right):

https://codereview.chromium.org/2152313002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js:224:
if (expandedProperties.has(propertyName))
Why is this inside "if (trace)" block?

[lushnikov, 2016-07-16 03:47:49]

https://codereview.chromium.org/2152313002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js
(right):

https://codereview.chromium.org/2152313002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js:224:
if (expandedProperties.has(propertyName))
On 2016/07/16 01:14:56, dgozman wrote:
> Why is this inside "if (trace)" block?

Only properties with traces are expandable; others aren't.

[lushnikov, 2016-07-16 03:47:53]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-07-16 03:48:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-16 03:53:16]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-16 03:55:42]

Description was changed from

==========
DevTools: preserve computed properties expansion on Computed Style re-rendering

Today, when the computed styles widget gets updated, it collapses all the
previously expanded properties.

This patch preserves property expansion on computed style re-rendering.

BUG=623317
R=dgozman
==========

to

==========
DevTools: preserve computed properties expansion on Computed Style re-rendering

Today, when the computed styles widget gets updated, it collapses all the
previously expanded properties.

This patch preserves property expansion on computed style re-rendering.

BUG=623317
R=dgozman

Committed: https://crrev.com/cd1ef8eab1d95051b259d196133ae35d1d0ee4da
Cr-Commit-Position: refs/heads/master@{#405929}
==========

[commit-bot: I haz the power, 2016-07-16 03:55:44]

Patchset 1 (id:??) landed as
https://crrev.com/cd1ef8eab1d95051b259d196133ae35d1d0ee4da
Cr-Commit-Position: refs/heads/master@{#405929}