Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js

Issue 2152293002: DevTools: kill WI.SourcesView._showFile method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 10 *
(...skipping 194 matching lines...) Expand 10 before | Expand all | Expand 10 after
205 205
206 this._removeViewListeners(); 206 this._removeViewListeners();
207 this._currentFile = uiSourceCode; 207 this._currentFile = uiSourceCode;
208 208
209 var tabId = this._tabIds.get(uiSourceCode) || this._appendFileTab(uiSour ceCode, userGesture); 209 var tabId = this._tabIds.get(uiSourceCode) || this._appendFileTab(uiSour ceCode, userGesture);
210 210
211 this._tabbedPane.selectTab(tabId, userGesture); 211 this._tabbedPane.selectTab(tabId, userGesture);
212 if (userGesture) 212 if (userGesture)
213 this._editorSelectedByUserAction(); 213 this._editorSelectedByUserAction();
214 214
215 var previousView = this._currentView;
215 this._currentView = this.visibleView; 216 this._currentView = this.visibleView;
216 this._addViewListeners(); 217 this._addViewListeners();
217 218
218 var eventData = { currentFile: this._currentFile, userGesture: userGestu re }; 219 var eventData = {
220 currentFile: this._currentFile,
221 currentView: this._currentView,
222 previousView: previousView,
223 userGesture: userGesture
224 };
219 this.dispatchEventToListeners(WebInspector.TabbedEditorContainer.Events. EditorSelected, eventData); 225 this.dispatchEventToListeners(WebInspector.TabbedEditorContainer.Events. EditorSelected, eventData);
220 }, 226 },
221 227
222 /** 228 /**
223 * @param {!WebInspector.UISourceCode} uiSourceCode 229 * @param {!WebInspector.UISourceCode} uiSourceCode
224 * @return {string} 230 * @return {string}
225 */ 231 */
226 _titleForFile: function(uiSourceCode) 232 _titleForFile: function(uiSourceCode)
227 { 233 {
228 var maxDisplayNameLength = 30; 234 var maxDisplayNameLength = 30;
(...skipping 511 matching lines...) Expand 10 before | Expand all | Expand 10 after
740 /** 746 /**
741 * @override 747 * @override
742 * @param {string} tabId 748 * @param {string} tabId
743 * @param {!WebInspector.ContextMenu} contextMenu 749 * @param {!WebInspector.ContextMenu} contextMenu
744 */ 750 */
745 onContextMenu: function(tabId, contextMenu) 751 onContextMenu: function(tabId, contextMenu)
746 { 752 {
747 this._editorContainer._onContextMenu(tabId, contextMenu); 753 this._editorContainer._onContextMenu(tabId, contextMenu);
748 } 754 }
749 } 755 }
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698