Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Issue 2152293002: DevTools: kill WI.SourcesView._showFile method (Closed)

Created:
4 years, 5 months ago by lushnikov
Modified:
4 years, 5 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: kill WI.SourcesView._showFile method The patch slightly untangles WI.SourcesView from WI.TabbedEditorContainer so that they don't jump to and fro to open a file in a tab. BUG=none R=pfeldman, dgozman Committed: https://crrev.com/979c67750586449ce539ed49aed2186b52b345cf Cr-Commit-Position: refs/heads/master@{#405862}

Patch Set 1 #

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -40 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js View 1 4 chunks +22 lines, -39 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
lushnikov
please, take a look
4 years, 5 months ago (2016-07-15 18:26:22 UTC) #1
pfeldman
lgtm. Thanks!
4 years, 5 months ago (2016-07-15 21:20:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2152293002/20001
4 years, 5 months ago (2016-07-15 21:21:48 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-15 21:26:45 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 21:28:34 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/979c67750586449ce539ed49aed2186b52b345cf
Cr-Commit-Position: refs/heads/master@{#405862}

Powered by Google App Engine
This is Rietveld 408576698