Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2642)

Unified Diff: content/test/gpu/gpu_tests/context_lost.py

Issue 2152283004: Abort ContextLost.WebGLContextLostFromQuantity if context creation fails. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/test/data/gpu/webgl.html ('k') | content/test/gpu/gpu_tests/context_lost_expectations.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/gpu/gpu_tests/context_lost.py
diff --git a/content/test/gpu/gpu_tests/context_lost.py b/content/test/gpu/gpu_tests/context_lost.py
index 433248901df3622f92d578c9942b6ac67ae36774..5d0100963fd6b1335915ef3b828df5a78e68f4ae 100644
--- a/content/test/gpu/gpu_tests/context_lost.py
+++ b/content/test/gpu/gpu_tests/context_lost.py
@@ -32,9 +32,13 @@ harness_script = r"""
if (msg == "loaded") {
domAutomationController._loaded = true;
} else if (msg == "success") {
- domAutomationController._succeeded = true;
+ /* Don't squelch earlier failures! */
+ if (!domAutomationController._finished) {
+ domAutomationController._succeeded = true;
+ }
domAutomationController._finished = true;
} else {
+ /* Always record failures. */
domAutomationController._succeeded = false;
domAutomationController._finished = true;
}
« no previous file with comments | « content/test/data/gpu/webgl.html ('k') | content/test/gpu/gpu_tests/context_lost_expectations.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698