Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 2152283004: Abort ContextLost.WebGLContextLostFromQuantity if context creation fails. (Closed)

Created:
4 years, 5 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 5 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, ynovikov
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Abort ContextLost.WebGLContextLostFromQuantity if context creation fails. Mark the test flaky on Win Debug (can't identify this separately from Win x64 Debug). Add better logging. BUG=628697 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/fe47448d071d22a0cf1d636e00c8c5808168b853 Cr-Commit-Position: refs/heads/master@{#405919}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M content/test/data/gpu/webgl.html View 1 chunk +3 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/context_lost.py View 1 chunk +5 lines, -1 line 0 comments Download
M content/test/gpu/gpu_tests/context_lost_expectations.py View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Ken Russell (switch to Gerrit)
PTAL
4 years, 5 months ago (2016-07-16 00:41:40 UTC) #3
Zhenyao Mo
lgtm
4 years, 5 months ago (2016-07-16 00:43:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2152283004/1
4 years, 5 months ago (2016-07-16 00:48:16 UTC) #6
commit-bot: I haz the power
Failed to apply the patch.
4 years, 5 months ago (2016-07-16 02:03:08 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-16 02:03:10 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-16 02:03:27 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe47448d071d22a0cf1d636e00c8c5808168b853
Cr-Commit-Position: refs/heads/master@{#405919}

Powered by Google App Engine
This is Rietveld 408576698