Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2152253002: [ARM] Generate flag setting instructions for arm. (Closed)

Created:
4 years, 5 months ago by georgia.kouveli
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ARM] Generate flag setting instructions for arm. Based on 317dc0578. BUG= Committed: https://crrev.com/c5987966431874d3b1abff7bce8606a8448ef7a1 Cr-Commit-Position: refs/heads/master@{#37828}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+379 lines, -2 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 4 chunks +135 lines, -2 lines 0 comments Download
M test/unittests/compiler/arm/instruction-selector-arm-unittest.cc View 1 chunk +244 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
georgia.kouveli
4 years, 5 months ago (2016-07-15 15:55:27 UTC) #3
Benedikt Meurer
Thanks, LGTM.
4 years, 5 months ago (2016-07-16 13:01:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2152253002/1
4 years, 5 months ago (2016-07-18 09:55:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 10:18:18 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 10:18:19 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 10:21:49 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c5987966431874d3b1abff7bce8606a8448ef7a1
Cr-Commit-Position: refs/heads/master@{#37828}

Powered by Google App Engine
This is Rietveld 408576698