[Autofill] Tweak credit card signin promo visually.

chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/autofill/autofill_popup_controller_impl.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/macros.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "chrome/browser/ui/autofill/autofill_popup_view.h"
+#include "chrome/browser/ui/autofill/popup_constants.h"
 #include "components/autofill/core/browser/autofill_popup_delegate.h"
 #include "components/autofill/core/browser/popup_item_ids.h"
 #include "components/autofill/core/browser/suggestion.h"
 #include "content/public/browser/native_web_keyboard_event.h"
 #include "ui/events/event.h"
 #include "ui/gfx/text_elider.h"
 #include "ui/gfx/text_utils.h"
 
 using base::WeakPtr;
 
@@ skipping 375 matching lines @@
 
   // All other message types are defined here.
   PopupItemId id = static_cast<PopupItemId>(suggestions_[index].frontend_id);
   switch (id) {
     case POPUP_ITEM_ID_WARNING_MESSAGE:
       return warning_font_list_;
     case POPUP_ITEM_ID_CLEAR_FORM:
     case POPUP_ITEM_ID_AUTOFILL_OPTIONS:
     case POPUP_ITEM_ID_SCAN_CREDIT_CARD:
     case POPUP_ITEM_ID_SEPARATOR:
+      return normal_font_list_;
     case POPUP_ITEM_ID_CREDIT_CARD_SIGNIN_PROMO:
-      return normal_font_list_;
+      return smaller_font_list_;
     case POPUP_ITEM_ID_TITLE:
     case POPUP_ITEM_ID_AUTOCOMPLETE_ENTRY:
     case POPUP_ITEM_ID_DATALIST_ENTRY:
     case POPUP_ITEM_ID_PASSWORD_ENTRY:
       return bold_font_list_;
   }
   NOTREACHED();
   return normal_font_list_;
 }
 
 const gfx::FontList& AutofillPopupControllerImpl::GetLabelFontList() const {
   return smaller_font_list_;
 }
 #endif
 
+SkColor AutofillPopupControllerImpl::GetBackgroundColorForRow(int index) const {
+  if (index == selected_line_) {
+    return kHoveredBackgroundColor;
+  } else if (suggestions_[index].frontend_id ==

[Evan Stade, 2016/07/18 17:52:56]

nit: no else after return

[Mathieu, 2016/07/18 18:01:41]

Done.

+             POPUP_ITEM_ID_CREDIT_CARD_SIGNIN_PROMO) {
+    return kPromoPopupBackground;
+  }
+
+  return SK_ColorWHITE;

[Evan Stade, 2016/07/18 17:52:56]

this is redundant with kPopupBackground. You should probably return
SK_ColorTRANSPARENT

[Mathieu, 2016/07/18 18:01:41]

Done.

+}
+
 int AutofillPopupControllerImpl::selected_line() const {
   return selected_line_;
 }
 
 const AutofillPopupLayoutModel& AutofillPopupControllerImpl::layout_model()
     const {
   return layout_model_;
 }
 
 void AutofillPopupControllerImpl::SetSelectedLine(int selected_line) {
@@ skipping 132 matching lines @@
   // Don't clear view_, because otherwise the popup will have to get regenerated
   // and this will cause flickering.
   suggestions_.clear();
   elided_values_.clear();
   elided_labels_.clear();
 
   selected_line_ = kNoSelection;
 }
 
 }  // namespace autofill