Vaidate Clear and ClearBuffer calls match the buffer types.

Vaidate Clear and ClearBuffer calls match the buffer types.

BUG=429053
TEST=webgl2_conformance
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/20c5b3b3c34113b83f365def5863b3c41b4b4283
Cr-Commit-Position: refs/heads/master@{#405928}

[Zhenyao Mo, 2016-07-15 14:35:17]

Description was changed from

==========
Vaidate Clear and ClearBuffer calls match the buffer types.

BUG=429053
TEST=webgl2_conformance
R=piman@chromium.org
==========

to

==========
Vaidate Clear and ClearBuffer calls match the buffer types.

BUG=429053
TEST=webgl2_conformance
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-07-15 18:15:17]

piman: Please take a look.

All webgl2 conformance failures have been addressed in
https://github.com/KhronosGroup/WebGL/pull/1886

I'll roll that in before landing this CL.

[Zhenyao Mo, 2016-07-15 18:15:53]

kbr, cwallez: FYI

[Ken Russell (switch to Gerrit), 2016-07-15 22:48:13]

kbr@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-07-15 22:48:14]

Thanks for the heads up. It looks like the trybot failures are real, but please
tell me if you see any flakes. Thanks.

[Zhenyao Mo, 2016-07-15 22:52:08]

On 2016/07/15 22:48:14, Ken Russell wrote:
> Thanks for the heads up. It looks like the trybot failures are real, but
please
> tell me if you see any flakes. Thanks.

Yes, I missed one test fix.

I am preparing a pull request right now.

[Ken Russell (switch to Gerrit), 2016-07-16 00:59:20]

Looks great. LGTM

[Zhenyao Mo, 2016-07-16 01:22:48]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-16 01:23:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-16 01:24:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-16 01:24:18]

Dry run: Try jobs failed on following builders:
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[Zhenyao Mo, 2016-07-16 02:29:38]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-16 02:29:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-16 03:29:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-16 03:29:22]

Dry run: This issue passed the CQ dry run.

[Zhenyao Mo, 2016-07-16 03:37:26]

The CQ bit was checked by zmo@chromium.org

[Zhenyao Mo, 2016-07-16 03:37:26]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2152213002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-07-16 03:37:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-16 03:43:20]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-16 03:45:04]

Description was changed from

==========
Vaidate Clear and ClearBuffer calls match the buffer types.

BUG=429053
TEST=webgl2_conformance
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Vaidate Clear and ClearBuffer calls match the buffer types.

BUG=429053
TEST=webgl2_conformance
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/20c5b3b3c34113b83f365def5863b3c41b4b4283
Cr-Commit-Position: refs/heads/master@{#405928}
==========

[commit-bot: I haz the power, 2016-07-16 03:45:05]

Patchset 4 (id:??) landed as
https://crrev.com/20c5b3b3c34113b83f365def5863b3c41b4b4283
Cr-Commit-Position: refs/heads/master@{#405928}

[piman, 2016-07-18 04:15:04]

lgtm