Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2152173002: Fix static race in DatabaseAuthorizer's whitelistedFunctions. (Closed)

Created:
4 years, 5 months ago by esprehn
Modified:
4 years, 5 months ago
Reviewers:
haraken, jsbell
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix static race in DatabaseAuthorizer's whitelistedFunctions. The DatabaseAuthorizer is created on the main thread but used on the database thread, we should use a thread safe static local to do the init. BUG=628480 Committed: https://crrev.com/24bf381b82d0222181a2d3f8e2184e07c35989da Cr-Commit-Position: refs/heads/master@{#405727}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/modules/webdatabase/DatabaseAuthorizer.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
esprehn
4 years, 5 months ago (2016-07-15 08:45:42 UTC) #6
haraken
LGTM
4 years, 5 months ago (2016-07-15 08:46:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2152173002/1
4 years, 5 months ago (2016-07-15 08:48:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 08:53:07 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 08:53:08 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 08:55:09 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/24bf381b82d0222181a2d3f8e2184e07c35989da
Cr-Commit-Position: refs/heads/master@{#405727}

Powered by Google App Engine
This is Rietveld 408576698