Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2152163002: Use LLD on 'LTO Linux' and 'LTO Linux Perf' buildbots. (Closed)

Created:
4 years, 5 months ago by krasin
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, ruiu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use LLD on 'LTO Linux' and 'LTO Linux Perf' buildbots. These are the first two bots to use LLD in LTO mode. BUG=607968

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M tools/mb/mb_config.pyl View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
krasin
4 years, 5 months ago (2016-07-15 02:37:08 UTC) #2
pcc1
I don't think this will work just yet because the clang package does not include ...
4 years, 5 months ago (2016-07-15 02:38:52 UTC) #3
krasin
On 2016/07/15 02:38:52, pcc1 wrote: > I don't think this will work just yet because ...
4 years, 5 months ago (2016-07-15 02:40:22 UTC) #4
Dirk Pranke
lgtm if you ensure the linker is actually there ;).
4 years, 5 months ago (2016-07-15 02:51:05 UTC) #5
krasin
Thank you, Dirk for the usual instant reply. I will first figure out the situation ...
4 years, 5 months ago (2016-07-15 02:53:04 UTC) #6
Nico
4 years, 5 months ago (2016-07-15 11:04:05 UTC) #7
Message was sent while issue was closed. 
On 2016/07/15 02:53:04, krasin wrote:
> Thank you, Dirk for the usual instant reply. I will first figure out the
> situation with the linker and then consider submitting this.

What's the advantage of toggling this bot by bit? Why not toggle the default in
the gyp file?

Powered by Google App Engine
This is Rietveld 408576698