Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2152153003: [Android] Guard some NDK workarounds by major version. (Closed)

Created:
4 years, 5 months ago by jbudorick
Modified:
4 years, 5 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : remove errant space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M src/common/android/include/sys/user.h View 1 3 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
jbudorick
4 years, 5 months ago (2016-07-15 17:15:42 UTC) #2
Mark Mentovai
LGTM
4 years, 5 months ago (2016-07-15 17:18:01 UTC) #3
jbudorick
On 2016/07/15 17:18:01, Mark Mentovai wrote: > LGTM er... How do I land this? `git ...
4 years, 5 months ago (2016-07-15 17:47:50 UTC) #4
Mark Mentovai
I added you to the ACL. Try again now.
4 years, 5 months ago (2016-07-15 19:19:55 UTC) #5
jbudorick
Committed patchset #2 (id:20001) manually as 965424f183596292e7df89404f16c420bdcdf9e1 (presubmit successful).
4 years, 5 months ago (2016-07-15 19:49:49 UTC) #7
jbudorick
4 years, 5 months ago (2016-07-15 19:50:15 UTC) #8
Message was sent while issue was closed.
On 2016/07/15 19:19:55, Mark Mentovai wrote:
> I added you to the ACL. Try again now.

That worked, obviously. Thanks!

Powered by Google App Engine
This is Rietveld 408576698