Automatically update LogDnsClient's DNS config

Automatically update LogDnsClient's DNS config

No need to pre-configure the net::DnsClient and it will pick up changes to the
system DNS config automatically via net::NetworkChangeNotifier.

BUG=612439
Committed: https://crrev.com/3f5a7569fd1192ec9fe0df96c5a2eebbb2c273c1
Cr-Commit-Position: refs/heads/master@{#407170}

[Rob Percival, 2016-07-15 16:11:13]

The CQ bit was checked by robpercival@chromium.org to run a CQ dry run

[Rob Percival, 2016-07-15 16:11:32]

robpercival@chromium.org changed reviewers:
+ eranm@chromium.org, mmenke@chromium.org

[Rob Percival, 2016-07-15 16:11:32]

PTAL

[commit-bot: I haz the power, 2016-07-15 16:11:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 17:50:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 17:50:11]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Rob Percival, 2016-07-18 16:39:59]

robpercival@chromium.org changed reviewers:
+ juliatuttle@chromium.org

[Rob Percival, 2016-07-18 16:40:00]

Hi Julia, could you take a look at this please? It makes
certificate_transparency::LogDnsClient a DNSObserver so that it gets
notifications when the DNS config changes. It can then pass those changes on to
its DnsClient.

[Julia Tuttle, 2016-07-18 17:10:10]

On 2016/07/18 16:40:00, Rob Percival wrote:
> Hi Julia, could you take a look at this please? It makes
> certificate_transparency::LogDnsClient a DNSObserver so that it gets
> notifications when the DNS config changes. It can then pass those changes on
to
> its DnsClient.

lgtm.

[Eran Messeri, 2016-07-21 14:16:24]

lgtm with a minor comment.

https://codereview.chromium.org/2152143003/diff/1/components/certificate_tran...
File components/certificate_transparency/log_dns_client_unittest.cc (right):

https://codereview.chromium.org/2152143003/diff/1/components/certificate_tran...
components/certificate_transparency/log_dns_client_unittest.cc:277:
network_change_notifier_(net::NetworkChangeNotifier::CreateMock()) {
Please document the reason for the existence of this field.

[Rob Percival, 2016-07-21 14:45:10]

https://codereview.chromium.org/2152143003/diff/1/components/certificate_tran...
File components/certificate_transparency/log_dns_client_unittest.cc (right):

https://codereview.chromium.org/2152143003/diff/1/components/certificate_tran...
components/certificate_transparency/log_dns_client_unittest.cc:277:
network_change_notifier_(net::NetworkChangeNotifier::CreateMock()) {
On 2016/07/21 14:16:24, Eran Messeri wrote:
> Please document the reason for the existence of this field.

Done.

[mmenke, 2016-07-21 14:57:34]

Description was changed from

==========
Automatically update LogDnsClient's DNS config

No need to pre-configure the net::DnsClient and it will pick up changes to the
system DNS config automatically via net::NetworkChangeNotifier.

BUG=612439
==========

to

==========
Automatically update LogDnsClient's DNS config

No need to pre-configure the net::DnsClient and it will pick up changes to the
system DNS config automatically via net::NetworkChangeNotifier.

BUG=612439
==========

[mmenke, 2016-07-21 14:57:34]

mmenke@chromium.org changed reviewers:
- mmenke@chromium.org

[Rob Percival, 2016-07-22 15:46:44]

The CQ bit was checked by robpercival@chromium.org

[Rob Percival, 2016-07-22 15:46:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
juliatuttle@chromium.org, eranm@chromium.org
Link to the patchset: https://codereview.chromium.org/2152143003/#ps20001
(title: "Documents test members")

[commit-bot: I haz the power, 2016-07-22 15:47:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 16:23:05]

Description was changed from

==========
Automatically update LogDnsClient's DNS config

No need to pre-configure the net::DnsClient and it will pick up changes to the
system DNS config automatically via net::NetworkChangeNotifier.

BUG=612439
==========

to

==========
Automatically update LogDnsClient's DNS config

No need to pre-configure the net::DnsClient and it will pick up changes to the
system DNS config automatically via net::NetworkChangeNotifier.

BUG=612439
==========

[commit-bot: I haz the power, 2016-07-22 16:23:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-22 16:24:55]

Description was changed from

==========
Automatically update LogDnsClient's DNS config

No need to pre-configure the net::DnsClient and it will pick up changes to the
system DNS config automatically via net::NetworkChangeNotifier.

BUG=612439
==========

to

==========
Automatically update LogDnsClient's DNS config

No need to pre-configure the net::DnsClient and it will pick up changes to the
system DNS config automatically via net::NetworkChangeNotifier.

BUG=612439

Committed: https://crrev.com/3f5a7569fd1192ec9fe0df96c5a2eebbb2c273c1
Cr-Commit-Position: refs/heads/master@{#407170}
==========

[commit-bot: I haz the power, 2016-07-22 16:24:56]

Patchset 2 (id:??) landed as
https://crrev.com/3f5a7569fd1192ec9fe0df96c5a2eebbb2c273c1
Cr-Commit-Position: refs/heads/master@{#407170}