Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2152143002:
Compress chrome://history's resources (Closed)
|
Created:
4 years, 5 months ago by Dan Beam Modified:
4 years, 3 months ago CC:
chromium-reviews, Patrick Dubroy, dbeam+watch-history_chromium.org, pam+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@compress-webui Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionCompress chrome://history's resources
Theoretically shaves 78658 bytes[1] off of resources.pak's on-disk size
(which is especially helpful on Android).
R=agrieve@chromium.org,smaier@chromium.org
BUG=619091
[1] https://docs.google.com/spreadsheets/d/1iHF05utMcECxc8tb3ziHQlEJmXlk98-PFWhkGoY545Q/edit
Committed: https://crrev.com/9dcdbe36c99b33e9205338cf58e9a38620b365e9
Cr-Commit-Position: refs/heads/master@{#419110}
Patch Set 1 #Patch Set 2 : merge #Patch Set 3 : merge #Patch Set 4 : merge #Patch Set 5 : . #Messages
Total messages: 44 (33 generated)
also, we could do this as well
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Compress chrome://history's resources Should save a bit of space in resources.pak for Android R=agrieve@chromium.org,smaier@chromium.org BUG= ========== to ========== Compress chrome://history's resources Should save a bit of space in resources.pak for Android R=agrieve@chromium.org,smaier@chromium.org BUG=619091 ==========
Description was changed from ========== Compress chrome://history's resources Should save a bit of space in resources.pak for Android R=agrieve@chromium.org,smaier@chromium.org BUG=619091 ========== to ========== Compress chrome://history's resources Theoretically shaved 78658 bytes off of resources.pak (which is especially helpful on Android). R=agrieve@chromium.org,smaier@chromium.org BUG=619091 ==========
Description was changed from ========== Compress chrome://history's resources Theoretically shaved 78658 bytes off of resources.pak (which is especially helpful on Android). R=agrieve@chromium.org,smaier@chromium.org BUG=619091 ========== to ========== Compress chrome://history's resources Theoretically shaves 78658 bytes off of resources.pak (which is especially helpful on Android). R=agrieve@chromium.org,smaier@chromium.org BUG=619091 ==========
Description was changed from ========== Compress chrome://history's resources Theoretically shaves 78658 bytes off of resources.pak (which is especially helpful on Android). R=agrieve@chromium.org,smaier@chromium.org BUG=619091 ========== to ========== Compress chrome://history's resources Theoretically shaves 78658 bytes[1] off of resources.pak (which is especially helpful on Android). R=agrieve@chromium.org,smaier@chromium.org BUG=619091 [1] https://docs.google.com/spreadsheets/d/1iHF05utMcECxc8tb3ziHQlEJmXlk98-PFWhkG... ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
Description was changed from ========== Compress chrome://history's resources Theoretically shaves 78658 bytes[1] off of resources.pak (which is especially helpful on Android). R=agrieve@chromium.org,smaier@chromium.org BUG=619091 [1] https://docs.google.com/spreadsheets/d/1iHF05utMcECxc8tb3ziHQlEJmXlk98-PFWhkG... ========== to ========== Compress chrome://history's resources Theoretically shaves 78658 bytes[1] off of resources.pak's on-disk size (which is especially helpful on Android). R=agrieve@chromium.org,smaier@chromium.org BUG=619091 [1] https://docs.google.com/spreadsheets/d/1iHF05utMcECxc8tb3ziHQlEJmXlk98-PFWhkG... ==========
On 2016/07/15 02:24:57, Dan Beam wrote: > also, we could do this as well I think it would make sense to also compress IDR_PROFILER_* and IDR_POLICY_* if we are going out of our way to do IDR_HISTORY_* already. This would result in another 75k of savings.
On 2016/07/15 13:47:44, smaier wrote: > On 2016/07/15 02:24:57, Dan Beam wrote: > > also, we could do this as well > > I think it would make sense to also compress IDR_PROFILER_* and IDR_POLICY_* if > we are going out of our way to do IDR_HISTORY_* already. This would result in > another 75k of savings. lgtm assuming you can fix the bots :P
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
i'm seeing a potential ~25% increase in one of the metrics this page logs (History.ResultsRenderedTime) when I use the gzipped version methodology: 0) rebuild clankium + adb to phone 1) open history with no visits 2) visit like 4 websites 3) open history again and refresh to get like ~20 total samples 4) visit chrome://histograms and search for "ResultsRenderedTime" and get the average For me, on a Nexus 5 I'm getting: Uncompressed: ~370ms avg Compressed: ~470ms avg Is there a better way to test this? Is this a non-starter?
i should also note that i used net-internals to verify the gzip filtering was actually kicking in
On 2016/09/16 01:11:39, Dan Beam wrote: > i should also note that i used net-internals to verify the gzip filtering was > actually kicking in lgtm
On 2016/09/16 01:33:49, agrieve wrote: > On 2016/09/16 01:11:39, Dan Beam wrote: > > i should also note that i used net-internals to verify the gzip filtering was > > actually kicking in > > lgtm I'd guess the speed hit is worth it since it's not an often visited page.
On 2016/09/16 01:49:03, agrieve wrote: > On 2016/09/16 01:33:49, agrieve wrote: > > On 2016/09/16 01:11:39, Dan Beam wrote: > > > i should also note that i used net-internals to verify the gzip filtering > was > > > actually kicking in > > > > lgtm > > I'd guess the speed hit is worth it since it's not an often visited page. aight, let's give it a try then
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Compress chrome://history's resources Theoretically shaves 78658 bytes[1] off of resources.pak's on-disk size (which is especially helpful on Android). R=agrieve@chromium.org,smaier@chromium.org BUG=619091 [1] https://docs.google.com/spreadsheets/d/1iHF05utMcECxc8tb3ziHQlEJmXlk98-PFWhkG... ========== to ========== Compress chrome://history's resources Theoretically shaves 78658 bytes[1] off of resources.pak's on-disk size (which is especially helpful on Android). R=agrieve@chromium.org,smaier@chromium.org BUG=619091 [1] https://docs.google.com/spreadsheets/d/1iHF05utMcECxc8tb3ziHQlEJmXlk98-PFWhkG... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Compress chrome://history's resources Theoretically shaves 78658 bytes[1] off of resources.pak's on-disk size (which is especially helpful on Android). R=agrieve@chromium.org,smaier@chromium.org BUG=619091 [1] https://docs.google.com/spreadsheets/d/1iHF05utMcECxc8tb3ziHQlEJmXlk98-PFWhkG... ========== to ========== Compress chrome://history's resources Theoretically shaves 78658 bytes[1] off of resources.pak's on-disk size (which is especially helpful on Android). R=agrieve@chromium.org,smaier@chromium.org BUG=619091 [1] https://docs.google.com/spreadsheets/d/1iHF05utMcECxc8tb3ziHQlEJmXlk98-PFWhkG... Committed: https://crrev.com/9dcdbe36c99b33e9205338cf58e9a38620b365e9 Cr-Commit-Position: refs/heads/master@{#419110} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/9dcdbe36c99b33e9205338cf58e9a38620b365e9 Cr-Commit-Position: refs/heads/master@{#419110} |
