Issue 21521002: Use test(reg, imm) when the operand is a register on ia32

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21521002: Use test(reg, imm) when the operand is a register on ia32 (Closed)

Created:
7 years, 4 months ago by weiliang.lin2

Modified:
7 years, 4 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Use test(reg, imm) when the operand is a register on ia32 R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16020

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	src/ia32/assembler-ia32.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

Jakob Kummerow

Why not move this logic into void Assembler::test(const Operand& op, const Immediate& imm) in assembler-ia32.cc, ...

7 years, 4 months ago (2013-08-01 11:28:36 UTC) #2

weiliang.lin2

On 2013/08/01 11:28:36, Jakob wrote: > Why not move this logic into void Assembler::test(const Operand& ...

7 years, 4 months ago (2013-08-01 13:15:12 UTC) #3

Jakob Kummerow

7 years, 4 months ago (2013-08-02 08:55:31 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r16020 (presubmit successful).