Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2152093002: DevTools: fix compilation for the VBoxes with toolbar items. (Closed)

Created:
4 years, 5 months ago by pfeldman
Modified:
4 years, 5 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, asvitkine+watch_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix compilation for the VBoxes with toolbar items. Committed: https://crrev.com/62a21773df0bdddd43f8efe195784d0710103cb6 Cr-Commit-Position: refs/heads/master@{#405925}

Patch Set 1 #

Patch Set 2 : lcean #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -53 lines) Patch
M third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/ApplicationCacheItemsView.js View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/DatabaseQueryView.js View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/DatabaseTableView.js View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js View 5 chunks +4 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
pfeldman
4 years, 5 months ago (2016-07-15 21:47:14 UTC) #2
dgozman
lgtm
4 years, 5 months ago (2016-07-15 21:54:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2152093002/20001
4 years, 5 months ago (2016-07-15 22:08:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/256890)
4 years, 5 months ago (2016-07-16 00:25:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2152093002/20001
4 years, 5 months ago (2016-07-16 01:28:10 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-16 02:42:47 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-16 02:44:34 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/62a21773df0bdddd43f8efe195784d0710103cb6
Cr-Commit-Position: refs/heads/master@{#405925}

Powered by Google App Engine
This is Rietveld 408576698