Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2152073002: Removed const from RenderWidgetHostView::GetSelectedText() (Closed)

Created:
4 years, 5 months ago by EhsanK
Modified:
4 years, 5 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nasko+codewatch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed const from RenderWidgetHostView::GetSelectedText() This method is only used by a test (WebViewInteractiveTest.TextSelection) and may eventually be removed. In the meantime, comply with the content API guidelines by removing const from the public interface. This is also useful for a followup CL (https://codereview.chromium.org/2130133004). BUG=578168 Committed: https://crrev.com/c92562017c1fa1b8e54eff22315f1d4d4cd5d4aa Cr-Commit-Position: refs/heads/master@{#405870}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M content/browser/frame_host/render_widget_host_view_guest.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mus.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/render_widget_host_view.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (11 generated)
EhsanK
Please take a look.
4 years, 5 months ago (2016-07-14 23:18:54 UTC) #3
Charlie Reis
LGTM, but let's simplify the CL description. Just say: This method is only used by ...
4 years, 5 months ago (2016-07-14 23:23:23 UTC) #4
EhsanK
On 2016/07/14 23:23:23, Charlie Reis wrote: > LGTM, but let's simplify the CL description. Just ...
4 years, 5 months ago (2016-07-14 23:25:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2152073002/1
4 years, 5 months ago (2016-07-14 23:26:53 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/104396)
4 years, 5 months ago (2016-07-15 00:36:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2152073002/1
4 years, 5 months ago (2016-07-15 20:54:42 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 21:59:14 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 22:01:15 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c92562017c1fa1b8e54eff22315f1d4d4cd5d4aa
Cr-Commit-Position: refs/heads/master@{#405870}

Powered by Google App Engine
This is Rietveld 408576698