Removed const from RenderWidgetHostView::GetSelectedText()

Removed const from RenderWidgetHostView::GetSelectedText()

This method is only used by a test (WebViewInteractiveTest.TextSelection) and
may eventually be removed. In the meantime, comply with the content API
guidelines by removing const from the public interface. This is also useful for
a followup CL (https://codereview.chromium.org/2130133004).

BUG=578168
Committed: https://crrev.com/c92562017c1fa1b8e54eff22315f1d4d4cd5d4aa
Cr-Commit-Position: refs/heads/master@{#405870}

[EhsanK, 2016-07-14 23:18:05]

Description was changed from

==========
Removed const from RenderWidgetHostView::GetSelectedText()

This method is deprecated, but due to the dependency of
WebViewInteractiveTest.TextSelection
on it, we cannot remove it now (an initial attempt in
https://codereview.chromium.org/2149493004
was unsuccessful). This CL removes the const-ness from the public API to unblock
the const-ness problem in the ongoing CL for TextInputManager on TextSelection
tracking for
OOPIF (see https://codereview.chromium.org/2130133004).

BUG=578168
==========

to

==========
Removed const from RenderWidgetHostView::GetSelectedText()

This method is deprecated, but due to the dependency of
WebViewInteractiveTest.TextSelection
on it, we cannot remove it now (an initial attempt in
https://codereview.chromium.org/2149493004
was unsuccessful). This CL removes the const-ness from the public API to unblock
the const-ness problem in the ongoing CL for TextInputManager on TextSelection
tracking for
OOPIF (see https://codereview.chromium.org/2130133004).

BUG=578168
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[EhsanK, 2016-07-14 23:18:53]

ekaramad@chromium.org changed reviewers:
+ creis@chromium.org

[EhsanK, 2016-07-14 23:18:54]

Please take a look.

[Charlie Reis, 2016-07-14 23:23:23]

LGTM, but let's simplify the CL description.  Just say:

This method is only used by a test (WebViewInteractiveTest.TextSelection) and
may eventually be removed.  In the meantime, comply with the content API
guidelines by removing const from the public interface.  This is also useful for
a followup CL (https://codereview.chromium.org/2130133004).

[EhsanK, 2016-07-14 23:24:45]

Description was changed from

==========
Removed const from RenderWidgetHostView::GetSelectedText()

This method is deprecated, but due to the dependency of
WebViewInteractiveTest.TextSelection
on it, we cannot remove it now (an initial attempt in
https://codereview.chromium.org/2149493004
was unsuccessful). This CL removes the const-ness from the public API to unblock
the const-ness problem in the ongoing CL for TextInputManager on TextSelection
tracking for
OOPIF (see https://codereview.chromium.org/2130133004).

BUG=578168
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Removed const from RenderWidgetHostView::GetSelectedText()

This method is only used by a test (WebViewInteractiveTest.TextSelection) and
may eventually be removed. In the meantime, comply with the content API
guidelines by removing const from the public interface. This is also useful for
a followup CL (https://codereview.chromium.org/2130133004).

BUG=578168
==========

[EhsanK, 2016-07-14 23:25:03]

On 2016/07/14 23:23:23, Charlie Reis wrote:
> LGTM, but let's simplify the CL description.  Just say:
> 
> This method is only used by a test (WebViewInteractiveTest.TextSelection) and
> may eventually be removed.  In the meantime, comply with the content API
> guidelines by removing const from the public interface.  This is also useful
for
> a followup CL (https://codereview.chromium.org/2130133004).

Thanks Charlie! Done. Will CQ after dry-run.

[EhsanK, 2016-07-14 23:25:12]

The CQ bit was checked by ekaramad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 23:25:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[EhsanK, 2016-07-14 23:26:23]

The CQ bit was unchecked by ekaramad@chromium.org

[EhsanK, 2016-07-14 23:26:23]

The CQ bit was checked by ekaramad@chromium.org

[commit-bot: I haz the power, 2016-07-14 23:26:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 00:36:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 00:36:03]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[EhsanK, 2016-07-15 20:53:51]

The CQ bit was checked by ekaramad@chromium.org

[commit-bot: I haz the power, 2016-07-15 20:54:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 21:59:12]

Description was changed from

==========
Removed const from RenderWidgetHostView::GetSelectedText()

This method is only used by a test (WebViewInteractiveTest.TextSelection) and
may eventually be removed. In the meantime, comply with the content API
guidelines by removing const from the public interface. This is also useful for
a followup CL (https://codereview.chromium.org/2130133004).

BUG=578168
==========

to

==========
Removed const from RenderWidgetHostView::GetSelectedText()

This method is only used by a test (WebViewInteractiveTest.TextSelection) and
may eventually be removed. In the meantime, comply with the content API
guidelines by removing const from the public interface. This is also useful for
a followup CL (https://codereview.chromium.org/2130133004).

BUG=578168
==========

[commit-bot: I haz the power, 2016-07-15 21:59:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-15 22:01:14]

Description was changed from

==========
Removed const from RenderWidgetHostView::GetSelectedText()

This method is only used by a test (WebViewInteractiveTest.TextSelection) and
may eventually be removed. In the meantime, comply with the content API
guidelines by removing const from the public interface. This is also useful for
a followup CL (https://codereview.chromium.org/2130133004).

BUG=578168
==========

to

==========
Removed const from RenderWidgetHostView::GetSelectedText()

This method is only used by a test (WebViewInteractiveTest.TextSelection) and
may eventually be removed. In the meantime, comply with the content API
guidelines by removing const from the public interface. This is also useful for
a followup CL (https://codereview.chromium.org/2130133004).

BUG=578168

Committed: https://crrev.com/c92562017c1fa1b8e54eff22315f1d4d4cd5d4aa
Cr-Commit-Position: refs/heads/master@{#405870}
==========

[commit-bot: I haz the power, 2016-07-15 22:01:15]

Patchset 1 (id:??) landed as
https://crrev.com/c92562017c1fa1b8e54eff22315f1d4d4cd5d4aa
Cr-Commit-Position: refs/heads/master@{#405870}