Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: third_party/protobuf/BUILD.gn

Issue 2152033002: Convert third_party source sets to static libraries. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ios Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/ots/BUILD.gn ('k') | third_party/qcms/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/protobuf/BUILD.gn
diff --git a/third_party/protobuf/BUILD.gn b/third_party/protobuf/BUILD.gn
index 8709b402e0ac1f7f0d3e0e8f17aa75ea40f5dbd8..84c916a651e8347ae93661d3056337fe4a060e7d 100644
--- a/third_party/protobuf/BUILD.gn
+++ b/third_party/protobuf/BUILD.gn
@@ -175,7 +175,7 @@ component("protobuf_lite") {
# This is the full, heavy protobuf lib that's needed for c++ .protos that don't
# specify the LITE_RUNTIME option. The protocol compiler itself (protoc) falls
# into that category. Do not use in Chrome code.
-source_set("protobuf_full") {
+static_library("protobuf_full") {
# Prevent people from depending on this outside our file.
visibility = [ ":*" ]
@@ -338,7 +338,7 @@ if (current_toolchain == host_toolchain) {
# protoc compiler is separated into protoc library and executable targets to
# support protoc plugins that need to link libprotoc, but not the main()
# itself. See src/google/protobuf/compiler/plugin.h
- source_set("protoc_lib") {
+ static_library("protoc_lib") {
sources = [
"src/google/protobuf/compiler/code_generator.cc",
"src/google/protobuf/compiler/code_generator.h",
« no previous file with comments | « third_party/ots/BUILD.gn ('k') | third_party/qcms/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698