Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2152033002: Convert third_party source sets to static libraries. (Closed)

Created:
4 years, 5 months ago by brettw
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, jzern, urvang, skal, rlp+watch_chromium.org, rouslan+spell_chromium.org, groby+spellwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert third_party source sets to static libraries. This covers the third_party code checked directly into Chrome. BUG=627637 Committed: https://crrev.com/23302cf2b607bcfa33f7b93860e69d5a49a47635 Cr-Commit-Position: refs/heads/master@{#405651}

Patch Set 1 #

Patch Set 2 : Unoverlap #

Patch Set 3 : ios #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -45 lines) Patch
M base/third_party/libevent/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M base/third_party/symbolize/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M base/third_party/xdg_mime/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M base/third_party/xdg_user_dirs/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/third_party/mozilla_security_manager/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/ced/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/cld_2/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/dom_distiller_js/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/fips181/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/hunspell/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/iccjpeg/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libXNVCtrl/BUILD.gn View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/libjingle/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/libsecret/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libwebm/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libwebp/BUILD.gn View 8 chunks +8 lines, -8 lines 0 comments Download
M third_party/mesa/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/modp_b64/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/opus/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/ots/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/protobuf/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/qcms/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/smhasher/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/wayland/BUILD.gn View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/woff2/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/yasm/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (12 generated)
brettw
4 years, 5 months ago (2016-07-14 21:30:47 UTC) #3
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-14 21:42:05 UTC) #8
brettw
ios
4 years, 5 months ago (2016-07-14 23:16:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2152033002/40001
4 years, 5 months ago (2016-07-14 23:17:30 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-15 00:54:28 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 00:54:30 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 00:57:00 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/23302cf2b607bcfa33f7b93860e69d5a49a47635
Cr-Commit-Position: refs/heads/master@{#405651}

Powered by Google App Engine
This is Rietveld 408576698