Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 2152023003: Remove unused content::GetWebKitMajorVersion() and content::GetWebKitMinorVersion(). (Closed)

Created:
4 years, 5 months ago by jam
Modified:
4 years, 5 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused content::GetWebKitMajorVersion() and content::GetWebKitMinorVersion(). Committed: https://crrev.com/98574a69eef995905e0803bf340499d842c4d90f Cr-Commit-Position: refs/heads/master@{#406092}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M content/common/user_agent.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M content/public/common/user_agent.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
jam
4 years, 5 months ago (2016-07-18 18:00:51 UTC) #10
Avi (use Gerrit)
lgtm
4 years, 5 months ago (2016-07-18 18:08:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2152023003/40001
4 years, 5 months ago (2016-07-18 18:16:36 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/246645)
4 years, 5 months ago (2016-07-18 19:39:43 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2152023003/40001
4 years, 5 months ago (2016-07-18 20:11:01 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 5 months ago (2016-07-18 21:05:54 UTC) #18
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 21:06:16 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 21:08:13 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/98574a69eef995905e0803bf340499d842c4d90f
Cr-Commit-Position: refs/heads/master@{#406092}

Powered by Google App Engine
This is Rietveld 408576698