chrome/browser/notifications/platform_notification_service_unittest.cc - Issue 2151993002: [WebAPKs] Plumb service worker scope to notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/platform_notification_service_unittest.cc

Issue 2151993002: [WebAPKs] Plumb service worker scope to notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'master' into notification_scope Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/notifications/platform_notification_service_impl.cc ('K') | « chrome/browser/notifications/platform_notification_service_impl.cc ('k') | chrome/browser/push_messaging/push_messaging_notification_manager.h » ('j') | chrome/browser/push_messaging/push_messaging_notification_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/platform_notification_service_unittest.cc

diff --git a/chrome/browser/notifications/platform_notification_service_unittest.cc b/chrome/browser/notifications/platform_notification_service_unittest.cc

index 12872acc57629820439219d1222f1b3ce2cc7409..9e5ac79eca5539f0f31b1cf7c26092f2f33dffc0 100644

--- a/chrome/browser/notifications/platform_notification_service_unittest.cc

+++ b/chrome/browser/notifications/platform_notification_service_unittest.cc

@@ -266,8 +266,8 @@ TEST_F(PlatformNotificationServiceTest, DisplayPersistentNotificationMatches) {

notification_resources.action_icons.resize(notification_data.actions.size());

service()->DisplayPersistentNotification(

- profile(), 0u /* persistent notification */, GURL("https://chrome.com/"),

- notification_data, notification_resources);

+ profile(), 0u /* persistent notification */, GURL(),

+ GURL("https://chrome.com/"), notification_data, notification_resources);

ASSERT_EQ(1u, GetNotificationCount());

@@ -304,7 +304,7 @@ TEST_F(PlatformNotificationServiceTest, NotificationPermissionLastUsage) {

base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(1));

service()->DisplayPersistentNotification(

- profile(), 42 /* sw_registration_id */, origin,

+ profile(), 42 /* sw_registration_id */, GURL(), origin,

PlatformNotificationData(), NotificationResources());

base::Time after_persistent_notification =