Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3739)

Unified Diff: chrome/browser/notifications/platform_notification_service_interactive_uitest.cc

Issue 2151993002: [WebAPKs] Plumb service worker scope to notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge branch 'master' into notification_scope Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/platform_notification_service_interactive_uitest.cc
diff --git a/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc b/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc
index ddfa64361b8e9261a811ba43531717c3d0c76cc0..2d365a86f2d581f762ceb9d76ae5d26e87f9af5c 100644
--- a/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc
+++ b/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc
@@ -409,6 +409,19 @@ IN_PROC_BROWSER_TEST_F(PlatformNotificationServiceBrowserTest,
notification.origin_url().spec());
}
+IN_PROC_BROWSER_TEST_F(PlatformNotificationServiceBrowserTest,
+ PersistentNotificationServiceWorkerScope) {
+ RequestAndAcceptPermission();
+
+ // Creates a simple notification.
+ std::string script_result;
+ ASSERT_TRUE(RunScript("DisplayPersistentNotification()", &script_result));
+
+ const Notification& notification = ui_manager()->GetNotificationAt(0);
+
+ EXPECT_EQ(TestPageUrl().spec(), notification.service_worker_scope().spec());
+}
+
// TODO(felt): This DCHECKs when bubbles are enabled, when the file_url is
// persisted. crbug.com/502057
IN_PROC_BROWSER_TEST_F(PlatformNotificationServiceBrowserTest,

Powered by Google App Engine
This is Rietveld 408576698