chrome/browser/notifications/platform_notification_service_impl.h - Issue 2151993002: [WebAPKs] Plumb service worker scope to notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/platform_notification_service_impl.h

Issue 2151993002: [WebAPKs] Plumb service worker scope to notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'master' into notification_scope Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/notification_platform_bridge_android.cc ('k') | chrome/browser/notifications/platform_notification_service_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/platform_notification_service_impl.h

diff --git a/chrome/browser/notifications/platform_notification_service_impl.h b/chrome/browser/notifications/platform_notification_service_impl.h

index 88f0b080460467004935f412c48ff3de112c1e94..95b4d712e4674686290e5f39a5d8383e38544e2c 100644

--- a/chrome/browser/notifications/platform_notification_service_impl.h

+++ b/chrome/browser/notifications/platform_notification_service_impl.h

@@ -84,6 +84,7 @@ class PlatformNotificationServiceImpl

void DisplayPersistentNotification(

content::BrowserContext* browser_context,

int64_t persistent_notification_id,

+ const GURL& service_worker_scope,

const GURL& origin,

const content::PlatformNotificationData& notification_data,

const content::NotificationResources& notification_resources) override;

@@ -119,6 +120,7 @@ class PlatformNotificationServiceImpl

// through requires changing a whole lot of Notification constructor calls.

Notification CreateNotificationFromData(

Profile* profile,

+ const GURL& service_worker_scope,

const GURL& origin,

const content::PlatformNotificationData& notification_data,

const content::NotificationResources& notification_resources,