chrome/browser/notifications/notification.cc - Issue 2151993002: [WebAPKs] Plumb service worker scope to notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification.cc

Issue 2151993002: [WebAPKs] Plumb service worker scope to notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'master' into notification_scope Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/notification.h ('k') | chrome/browser/notifications/notification_platform_bridge_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification.cc

diff --git a/chrome/browser/notifications/notification.cc b/chrome/browser/notifications/notification.cc

index 1bd24964b3a866b642b6a3a134b9fb8eeb0c1fe1..cec64b27f64e53aa6ef25f7e8d324ae3bb332d14 100644

--- a/chrome/browser/notifications/notification.cc

+++ b/chrome/browser/notifications/notification.cc

@@ -32,12 +32,14 @@ Notification::Notification(const std::string& id,

const Notification& notification)

: message_center::Notification(id, notification),

tag_(notification.tag()),

+ service_worker_scope_(notification.service_worker_scope()),

delegate_(notification.delegate()) {

}

Notification::Notification(const Notification& notification)

: message_center::Notification(notification),

tag_(notification.tag()),

+ service_worker_scope_(notification.service_worker_scope()),

delegate_(notification.delegate()) {}

Notification::~Notification() {}

@@ -45,6 +47,7 @@ Notification::~Notification() {}

Notification& Notification::operator=(const Notification& notification) {

message_center::Notification::operator=(notification);

tag_ = notification.tag();

+ service_worker_scope_ = notification.service_worker_scope();

delegate_ = notification.delegate();

return *this;

}