chrome/browser/DEPS - Issue 2151993002: [WebAPKs] Plumb service worker scope to notifications

Side by Side Diff: chrome/browser/DEPS

Issue 2151993002: [WebAPKs] Plumb service worker scope to notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'master' into notification_scope Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+apps",	2 "+apps",

3 "+ash",	3 "+ash",

4 "+chrome/app",	4 "+chrome/app",

5 "+chrome/chrome_watcher",	5 "+chrome/chrome_watcher",

6 "+chrome/grit", # For generated headers	6 "+chrome/grit", # For generated headers

7 "+chrome/installer",	7 "+chrome/installer",

8 "+chrome_elf/blacklist",	8 "+chrome_elf/blacklist",

9 "+chrome_elf/chrome_elf_constants.h",	9 "+chrome_elf/chrome_elf_constants.h",

10 "+chrome_elf/create_file",	10 "+chrome_elf/create_file",

11 "+chrome_elf/dll_hash",	11 "+chrome_elf/dll_hash",

12 "+chromeos",	12 "+chromeos",

13 "+components",	13 "+components",

	14 "+content/browser/service_worker",

	15 "+content/common/service_worker",
	pkotwicz 2016/07/14 19:32:50 I suspect that I need to add ServiceWorkerContext: I suspect that I need to add ServiceWorkerContext::FindReadyRegistrationForId() ServiceWorkerRegistration is not in content/public/browser though... Peter Beverloo 2016/07/15 13:40:11 Sorry, we can't add these dependencies. See the do Show quoted text On 2016/07/14 19:32:50, pkotwicz wrote: > I suspect that I need to add ServiceWorkerContext::FindReadyRegistrationForId() > > ServiceWorkerRegistration is not in content/public/browser though... Sorry, we can't add these dependencies. See the documentation at: https://www.chromium.org/developers/content-module/content-api The general gist is that anything using //content must include files from the public API in //content/public/. As you spotted, SWR is not part of that. I'll suggest an alternative where you use these.
14 "+content/public/browser",	16 "+content/public/browser",

15 "+content/test/net",	17 "+content/test/net",

16 "+courgette",	18 "+courgette",

17 "+device/bluetooth",	19 "+device/bluetooth",

18 "+device/core",	20 "+device/core",

19 "+device/hid",	21 "+device/hid",

20 "+device/media_transfer_protocol",	22 "+device/media_transfer_protocol",

21 "+device/usb",	23 "+device/usb",

22 "+extensions/browser",	24 "+extensions/browser",

23 "+extensions/common",	25 "+extensions/common",

(...skipping 82 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
106 "+third_party/WebKit/public/platform/modules/permissions/permission_status.moj om.h",	108 "+third_party/WebKit/public/platform/modules/permissions/permission_status.moj om.h",

107 "+third_party/WebKit/public/web/WebCache.h",	109 "+third_party/WebKit/public/web/WebCache.h",

108 "+third_party/WebKit/public/web/WebContextMenuData.h",	110 "+third_party/WebKit/public/web/WebContextMenuData.h",

109 "+third_party/WebKit/public/web/WebFindOptions.h",	111 "+third_party/WebKit/public/web/WebFindOptions.h",

110 "+third_party/WebKit/public/web/WebInputEvent.h",	112 "+third_party/WebKit/public/web/WebInputEvent.h",

111 "+third_party/WebKit/public/web/WebMediaPlayerAction.h",	113 "+third_party/WebKit/public/web/WebMediaPlayerAction.h",

112 "+third_party/WebKit/public/web/WebPluginAction.h",	114 "+third_party/WebKit/public/web/WebPluginAction.h",

113 "+third_party/WebKit/public/web/WebTextDirection.h",	115 "+third_party/WebKit/public/web/WebTextDirection.h",

114 "+third_party/WebKit/public/web/WebWindowFeatures.h",	116 "+third_party/WebKit/public/web/WebWindowFeatures.h",

115 ]	117 ]

OLD	NEW

« no previous file with comments | « no previous file | chrome/browser/notifications/notification.h » ('j') | chrome/browser/notifications/platform_notification_service_impl.cc » ('J')