content/test/gpu/gpu_tests/gpu_integration_test.py - Issue 2151983002: Adding logic to restart the browser if there is an exception

Unified Diff: content/test/gpu/gpu_tests/gpu_integration_test.py

Issue 2151983002: Adding logic to restart the browser if there is an exception (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updating where the crash happens for the unittest Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/test/gpu/gpu_tests/gpu_integration_test_unittest.py » ('j') | content/test/gpu/gpu_tests/gpu_integration_test_unittest.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/test/gpu/gpu_tests/gpu_integration_test.py

diff --git a/content/test/gpu/gpu_tests/gpu_integration_test.py b/content/test/gpu/gpu_tests/gpu_integration_test.py

index 21a283be021fd1b200f1974ed6ae2319de4bd986..2f9128aacc9484a8835a4a55b6c61933e90bdb65 100644

--- a/content/test/gpu/gpu_tests/gpu_integration_test.py

+++ b/content/test/gpu/gpu_tests/gpu_integration_test.py

@@ -126,4 +126,9 @@ class GpuIntegrationTest(

raise NotImplementedError

def setUp(self):

- self.tab = self.browser.tabs[0]

+ try:

+ self.tab = self.browser.tabs[0]

+ except Exception:

Ken Russell (switch to Gerrit) 2016/07/15 18:05:24 Please call exception_formatter.PrintFormattedExce

nednguyen 2016/07/15 18:11:15 Recently I found out about pythons' log.exception(

Ken Russell (switch to Gerrit) 2016/07/16 01:09:54 Aha. Very good, we should file a cleanup bug. :)

eyaich 2016/07/21 17:58:06 Done.

+ # restart the browser to make sure a failure in a test doesn't

+ # propagate to the next test iteration.

+ self._RestartBrowser('failure in setup')

« no previous file with comments | « no previous file | content/test/gpu/gpu_tests/gpu_integration_test_unittest.py » ('j') | content/test/gpu/gpu_tests/gpu_integration_test_unittest.py » ('J')