Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2151973002: ash: Include transient descendants as part of the active modal window (Closed)

Created:
4 years, 5 months ago by xiyuan
Modified:
4 years, 5 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ash: Include transient descendants as part of the active modal window Modal window could have non-modal transient descendants. Those window should also receive events. BUG=626147 TEST=SystemModalContainerLayoutManagerTest.ModalTransientChildEvents Committed: https://crrev.com/f380ce142230c2b4c25d9eb92a4afb58ef62a524 Cr-Commit-Position: refs/heads/master@{#405589}

Patch Set 1 #

Patch Set 2 : add transient grand child test and git cl format #

Patch Set 3 : fix missing events for control in transient descendants #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -1 line) Patch
M ash/wm/system_modal_container_layout_manager.cc View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M ash/wm/system_modal_container_layout_manager_unittest.cc View 1 2 2 chunks +88 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
xiyuan
4 years, 5 months ago (2016-07-14 18:38:36 UTC) #2
xiyuan
Please hold off reviewing this. Just found this fixes the mouse events on file dialog ...
4 years, 5 months ago (2016-07-14 19:47:09 UTC) #9
xiyuan
Need to allow control window in transient descendants too. Ready for review now. Thanks.
4 years, 5 months ago (2016-07-14 20:25:16 UTC) #10
oshima
lgtm thank you for fixing this!
4 years, 5 months ago (2016-07-14 21:43:21 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151973002/40001
4 years, 5 months ago (2016-07-14 21:55:58 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-14 22:04:14 UTC) #18
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 22:04:28 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 22:06:11 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f380ce142230c2b4c25d9eb92a4afb58ef62a524
Cr-Commit-Position: refs/heads/master@{#405589}

Powered by Google App Engine
This is Rietveld 408576698