Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 2151943002: Revert of [Devtools] Improved URL parser for console (Closed)

Created:
4 years, 5 months ago by allada
Modified:
4 years, 5 months ago
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Devtools] Improved URL parser for console (patchset #6 id:100001 of https://codereview.chromium.org/2125143002/ ) Reason for revert: Regex can lockup on some console messages. Original issue's description: > [Devtools] Improved URL parser for console > > URL linkifier in console will now match a bit smarter. It > will now allow things in double quotes single quotes and tick > characters with something that beings to look like a url and > continue to match (ie: allow spaces and punctuation). If > there is no quote characters it will require punctuation or > space before and after something that looks like a url. > > BUG=535463 > > Committed: https://crrev.com/33b11974ba7343fbf2ad6673447488a1563cc8e3 > Cr-Commit-Position: refs/heads/master@{#404724} TBR=lushnikov@chromium.org,luoe@chromium.org,dgozman@chromium.org,allada@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=535463 Committed: https://crrev.com/477dadc20eba3bc2d0db28ee76728ded4b12ad1a Cr-Commit-Position: refs/heads/master@{#405534}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -204 lines) Patch
M third_party/WebKit/LayoutTests/inspector/console/console-log-linkify-links.html View 2 chunks +3 lines, -35 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-log-linkify-links-expected.txt View 2 chunks +5 lines, -111 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/Linkifier.js View 1 chunk +6 lines, -58 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
allada
Created Revert of [Devtools] Improved URL parser for console
4 years, 5 months ago (2016-07-14 17:34:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151943002/1
4 years, 5 months ago (2016-07-14 17:35:14 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-07-14 17:35:15 UTC) #5
dgozman
lgtm
4 years, 5 months ago (2016-07-14 17:45:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151943002/1
4 years, 5 months ago (2016-07-14 17:46:05 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 19:15:50 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 19:17:39 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/477dadc20eba3bc2d0db28ee76728ded4b12ad1a
Cr-Commit-Position: refs/heads/master@{#405534}

Powered by Google App Engine
This is Rietveld 408576698