third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp - Issue 2151933003: Change WTF::TemporaryChange to be an alias for AutoReset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp

Issue 2151933003: Change WTF::TemporaryChange to be an alias for AutoReset (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/SelectorChecker.cpp ('k') | third_party/WebKit/Source/core/dom/DOMURL.cpp » ('j') | third_party/WebKit/Source/core/dom/StyleEngine.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp

diff --git a/third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp b/third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp

index bd44cef0e1ffcd94280744e349e2061c102ed347..b088247a83f54876525f83409c0c059e08b0528c 100644

--- a/third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp

+++ b/third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp

@@ -34,7 +34,7 @@ namespace blink {

void ContextLifecycleNotifier::notifyResumingActiveDOMObjects()

{

- TemporaryChange<IterationState> scope(m_iterationState, AllowingNone);

+ TemporaryChange<IterationState> scope(&m_iterationState, AllowingNone);

for (ContextLifecycleObserver* observer : m_observers) {

if (observer->observerType() != ContextLifecycleObserver::ActiveDOMObjectType)

continue;

@@ -49,7 +49,7 @@ void ContextLifecycleNotifier::notifyResumingActiveDOMObjects()

void ContextLifecycleNotifier::notifySuspendingActiveDOMObjects()

{

- TemporaryChange<IterationState> scope(m_iterationState, AllowingNone);

+ TemporaryChange<IterationState> scope(&m_iterationState, AllowingNone);

for (ContextLifecycleObserver* observer : m_observers) {

if (observer->observerType() != ContextLifecycleObserver::ActiveDOMObjectType)

continue;

@@ -65,7 +65,7 @@ void ContextLifecycleNotifier::notifySuspendingActiveDOMObjects()

void ContextLifecycleNotifier::notifyStoppingActiveDOMObjects()

{

// Observers may be removed, but handled after iteration has completed.

- TemporaryChange<IterationState> scope(m_iterationState, AllowPendingRemoval);

+ TemporaryChange<IterationState> scope(&m_iterationState, AllowPendingRemoval);

ObserverSet observers;

m_observers.swap(observers);

for (ContextLifecycleObserver* observer : observers) {