third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp - Issue 2151933003: Change WTF::TemporaryChange to be an alias for AutoReset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp

Issue 2151933003: Change WTF::TemporaryChange to be an alias for AutoReset (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp

index a15d094951129b5ef7635a51d390cc4d3109b103..10dde3981156032d54ce564fdae0ab36b703964c 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp

@@ -96,7 +96,7 @@ void ScriptWrappableVisitor::RegisterV8References(const std::vector<std::pair<vo

bool ScriptWrappableVisitor::AdvanceTracing(double deadlineInMs, v8::EmbedderHeapTracer::AdvanceTracingActions actions)

{

DCHECK(m_tracingInProgress);

- WTF::TemporaryChange<bool>(m_advancingTracing, true);

+ WTF::TemporaryChange<bool>(&m_advancingTracing, true);

while (actions.force_completion == v8::EmbedderHeapTracer::ForceCompletionAction::FORCE_COMPLETION

|| WTF::monotonicallyIncreasingTimeMS() < deadlineInMs) {

if (m_markingDeque.isEmpty()) {

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/SelectorChecker.cpp » ('j') | third_party/WebKit/Source/core/dom/StyleEngine.h » ('J')