Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2151933002: DialogDelegate: allow platforms to prevent Cancel being default (Closed)

Created:
4 years, 5 months ago by Elly Fong-Jones
Modified:
4 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DialogDelegate: allow platforms to prevent Cancel being default On Mac, DIALOG_BUTTON_CANCEL should never have default button styling, so DialogDelegate::UpdateButton() should avoid setting cancel buttons as default. BUG=605652 Committed: https://crrev.com/9139823c60ba620c8d344e9ef70ea5f2eea680e0 Cr-Commit-Position: refs/heads/master@{#406276}

Patch Set 1 #

Patch Set 2 : fix unit test for mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M ui/views/style/platform_style.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/style/platform_style.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/style/platform_style_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/window/dialog_client_view_unittest.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/window/dialog_delegate.cc View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
Elly Fong-Jones
sky: ptal? :)
4 years, 5 months ago (2016-07-14 17:37:18 UTC) #3
sky
LGTM
4 years, 5 months ago (2016-07-18 15:50:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151933002/1
4 years, 5 months ago (2016-07-18 18:27:51 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/261750)
4 years, 5 months ago (2016-07-18 19:36:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151933002/20001
4 years, 5 months ago (2016-07-19 14:30:51 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-19 15:15:48 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 15:15:51 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 15:18:33 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9139823c60ba620c8d344e9ef70ea5f2eea680e0
Cr-Commit-Position: refs/heads/master@{#406276}

Powered by Google App Engine
This is Rietveld 408576698