Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 215193002: Removing webkit-prefixed image data HD APIs from 2D canvas (Closed)

Created:
6 years, 9 months ago by Justin Novosad
Modified:
6 years, 9 months ago
Reviewers:
Stephen White
CC:
blink-reviews, arv+blink, dglazkov+blink, Rik, adamk+blink_chromium.org, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Removing webkit-prefixed image data HD APIs from 2D canvas BUG=277205 R=senorblanco@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170324

Patch Set 1 #

Patch Set 2 : cleaned up obsolete tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -188 lines) Patch
D LayoutTests/fast/canvas/2d.backingStorePixelRatio.html View 1 1 chunk +0 lines, -31 lines 0 comments Download
D LayoutTests/fast/canvas/2d.backingStorePixelRatio-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/canvas/2d.imageDataHD.html View 1 1 chunk +0 lines, -118 lines 0 comments Download
D LayoutTests/fast/canvas/2d.imageDataHD-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/profiler/canvas2d/canvas2d-api-changes.html View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.idl View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Justin Novosad
PTAL
6 years, 9 months ago (2014-03-27 18:47:01 UTC) #1
Stephen White
LGTM
6 years, 9 months ago (2014-03-27 18:55:18 UTC) #2
Justin Novosad
The CQ bit was checked by junov@chromium.org
6 years, 9 months ago (2014-03-27 19:34:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junov@chromium.org/215193002/20001
6 years, 9 months ago (2014-03-27 19:34:16 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 21:25:11 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 21:25:11 UTC) #6
Justin Novosad
6 years, 9 months ago (2014-03-28 13:33:56 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r170324 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698