Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2151853002:
Fix a typo in PaymentInformation.java (Closed)
|
Created:
4 years, 5 months ago by Hwanseung Lee Modified:
4 years, 5 months ago CC:
chromium-reviews, Hwanseung Lee(hs1217.lee) Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix a typo in PaymentInformation.java
sippingAddresses -> shippingAddresses
BUG=None
Committed: https://crrev.com/83d412cfc1713d008ed8c77d44a37e17cae59957
Cr-Commit-Position: refs/heads/master@{#405505}
Patch Set 1 #
Total comments: 3
Patch Set 2 : Fix a typo in PaymentInformation.java #Patch Set 3 : Fix a typo in PaymentInformation.java #Patch Set 4 : Fix a typo in PaymentInformation.java #Messages
Total messages: 21 (8 generated)
Description was changed from ========== Fix a typo in PaymentInformation.java sippingAddresses -> shippingAddresses BUG=None ========== to ========== Fix a typo in PaymentInformation.java sippingAddresses -> shippingAddresses BUG=None ==========
hs1217.lee@samsung.com changed reviewers: + jinho.bang@samsung.com, rouslan@chromium.org
https://codereview.chromium.org/2151853002/diff/1/AUTHORS File AUTHORS (right): https://codereview.chromium.org/2151853002/diff/1/AUTHORS#newcode247 AUTHORS:247: Hwanseung Lee <hs1217.lee@samsung.com> rucifer1217@gmail.com is my old email. i will not be used this email anymore. and I would like to add a new e-mail.
could you review this commit? thank you.
https://codereview.chromium.org/2151853002/diff/1/AUTHORS File AUTHORS (right): https://codereview.chromium.org/2151853002/diff/1/AUTHORS#newcode247 AUTHORS:247: Hwanseung Lee <hs1217.lee@samsung.com> On 2016/07/14 13:49:31, Hwanseung Lee wrote: > mailto:rucifer1217@gmail.com is my old email. > i will not be used this email anymore. > and I would like to add a new e-mail. Please sign the license agreement using your new email: https://cla.developers.google.com/about/google-individual?csw=1 Are you still using hs1217.lee@gmail.com above? https://codereview.chromium.org/2151853002/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentInformation.java (right): https://codereview.chromium.org/2151853002/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentInformation.java:24: * @param paymentMethods The payment methods. Align all descriptions.
On 2016/07/14 14:35:37, Rouslan (ツ) wrote: > https://codereview.chromium.org/2151853002/diff/1/AUTHORS > File AUTHORS (right): > > https://codereview.chromium.org/2151853002/diff/1/AUTHORS#newcode247 > AUTHORS:247: Hwanseung Lee <mailto:hs1217.lee@samsung.com> > On 2016/07/14 13:49:31, Hwanseung Lee wrote: > > mailto:rucifer1217@gmail.com is my old email. > > i will not be used this email anymore. > > and I would like to add a new e-mail. > > Please sign the license agreement using your new email: > https://cla.developers.google.com/about/google-individual?csw=1 > > Are you still using mailto:hs1217.lee@gmail.com above? > > https://codereview.chromium.org/2151853002/diff/1/chrome/android/java/src/org... > File > chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentInformation.java > (right): > > https://codereview.chromium.org/2151853002/diff/1/chrome/android/java/src/org... > chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentInformation.java:24: > * @param paymentMethods The payment methods. > Align all descriptions. i signed Individual CLA temporary. i will figure out about corporate CLA after go to work. yes, i'm using "hs1217.lee@gmail.com" sometimes. and I had to change the alignment about descriptions.
lgtm No need to sign corporate CLA. Corporate CLA allows everyone in Samsung to commit. According to the AUTHORS file, each contributor from Samsung signs an individual contributor license.
The CQ bit was checked by rouslan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
rouslan@chromium.org changed reviewers: + dfalcantara@chromium.org
dfalcantara@, owners ptal.
lgtm
The CQ bit was checked by rouslan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix a typo in PaymentInformation.java sippingAddresses -> shippingAddresses BUG=None ========== to ========== Fix a typo in PaymentInformation.java sippingAddresses -> shippingAddresses BUG=None ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Fix a typo in PaymentInformation.java sippingAddresses -> shippingAddresses BUG=None ========== to ========== Fix a typo in PaymentInformation.java sippingAddresses -> shippingAddresses BUG=None Committed: https://crrev.com/83d412cfc1713d008ed8c77d44a37e17cae59957 Cr-Commit-Position: refs/heads/master@{#405505} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/83d412cfc1713d008ed8c77d44a37e17cae59957 Cr-Commit-Position: refs/heads/master@{#405505} |
