Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 2151853002: Fix a typo in PaymentInformation.java (Closed)

Created:
4 years, 5 months ago by Hwanseung Lee
Modified:
4 years, 5 months ago
CC:
chromium-reviews, Hwanseung Lee(hs1217.lee)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a typo in PaymentInformation.java sippingAddresses -> shippingAddresses BUG=None Committed: https://crrev.com/83d412cfc1713d008ed8c77d44a37e17cae59957 Cr-Commit-Position: refs/heads/master@{#405505}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fix a typo in PaymentInformation.java #

Patch Set 3 : Fix a typo in PaymentInformation.java #

Patch Set 4 : Fix a typo in PaymentInformation.java #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M AUTHORS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentInformation.java View 1 2 3 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
Hwanseung Lee
https://codereview.chromium.org/2151853002/diff/1/AUTHORS File AUTHORS (right): https://codereview.chromium.org/2151853002/diff/1/AUTHORS#newcode247 AUTHORS:247: Hwanseung Lee <hs1217.lee@samsung.com> rucifer1217@gmail.com is my old email. i ...
4 years, 5 months ago (2016-07-14 13:49:32 UTC) #3
Hwanseung Lee
could you review this commit? thank you.
4 years, 5 months ago (2016-07-14 14:01:25 UTC) #4
please use gerrit instead
https://codereview.chromium.org/2151853002/diff/1/AUTHORS File AUTHORS (right): https://codereview.chromium.org/2151853002/diff/1/AUTHORS#newcode247 AUTHORS:247: Hwanseung Lee <hs1217.lee@samsung.com> On 2016/07/14 13:49:31, Hwanseung Lee wrote: ...
4 years, 5 months ago (2016-07-14 14:35:37 UTC) #5
Hwanseung Lee
On 2016/07/14 14:35:37, Rouslan (ツ) wrote: > https://codereview.chromium.org/2151853002/diff/1/AUTHORS > File AUTHORS (right): > > https://codereview.chromium.org/2151853002/diff/1/AUTHORS#newcode247 ...
4 years, 5 months ago (2016-07-14 15:38:59 UTC) #6
please use gerrit instead
lgtm No need to sign corporate CLA. Corporate CLA allows everyone in Samsung to commit. ...
4 years, 5 months ago (2016-07-14 15:55:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151853002/60001
4 years, 5 months ago (2016-07-14 15:56:39 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/218169)
4 years, 5 months ago (2016-07-14 16:04:06 UTC) #11
please use gerrit instead
dfalcantara@, owners ptal.
4 years, 5 months ago (2016-07-14 16:07:32 UTC) #13
gone
lgtm
4 years, 5 months ago (2016-07-14 16:55:02 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151853002/60001
4 years, 5 months ago (2016-07-14 16:56:22 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-14 17:00:28 UTC) #18
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 17:00:39 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 17:02:10 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/83d412cfc1713d008ed8c77d44a37e17cae59957
Cr-Commit-Position: refs/heads/master@{#405505}

Powered by Google App Engine
This is Rietveld 408576698