Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2151843002: Revert of Reland "Don't compile functions in a context the caller doesn't have access to" (Closed)

Created:
4 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 5 months ago
Reviewers:
Toon Verwaest
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Reland "Don't compile functions in a context the caller doesn't have access to" (patchset #4 id:60001 of https://codereview.chromium.org/2143893005/ ) Reason for revert: blink is unhappy about the microtask change Original issue's description: > Reland "Don't compile functions in a context the caller doesn't have access to" > > Original issue's description: > > Don't compile functions in a context the caller doesn't have access to > > > > Instead just return undefined > > > > A side effect of this is that it's no longer possible to compile > > functions in a detached context. > > > > BUG=chromium:541703 > > R=verwaest@chromium.org,bmeurer@chromium.org > > BUG=chromium:541703 > R=verwaest@chromium.org > > Committed: https://crrev.com/6bceabac5b705b2ce1f52d34650cea1ae3b8c617 > Cr-Commit-Position: refs/heads/master@{#37756} TBR=verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:541703 Committed: https://crrev.com/63449d21d3c57831e3f7b9b7d500248070ffff3c Cr-Commit-Position: refs/heads/master@{#37760}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -188 lines) Patch
M include/v8.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/builtins/builtins.cc View 6 chunks +15 lines, -28 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/isolate.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +0 lines, -76 lines 0 comments Download
M test/mjsunit/cross-realm-filtering.js View 1 chunk +0 lines, -74 lines 0 comments Download
M test/mjsunit/es6/reflect-construct.js View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jochen (gone - plz use gerrit)
Created Revert of Reland "Don't compile functions in a context the caller doesn't have access ...
4 years, 5 months ago (2016-07-14 12:37:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151843002/1
4 years, 5 months ago (2016-07-14 12:37:11 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 12:37:26 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 12:39:20 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/63449d21d3c57831e3f7b9b7d500248070ffff3c
Cr-Commit-Position: refs/heads/master@{#37760}

Powered by Google App Engine
This is Rietveld 408576698