third_party/WebKit/Source/core/editing/EditingStrategy.cpp - Issue 2151803003: [Editing][Regression] Contenteditable w/ "-webkit-user-select:all" should be editable for drag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/EditingStrategy.cpp

Issue 2151803003: [Editing][Regression] Contenteditable w/ "-webkit-user-select:all" should be editable for drag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/editing/selection/user-select/user-select-all-contenteditable.html ('k') | third_party/WebKit/Source/core/editing/EditingUtilities.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/EditingStrategy.cpp

diff --git a/third_party/WebKit/Source/core/editing/EditingStrategy.cpp b/third_party/WebKit/Source/core/editing/EditingStrategy.cpp

index b85e35c2bfbc522f3b53d60f8733fcba6b115bac..009c944805d223a826dd9863b46387d812e58ea6 100644

--- a/third_party/WebKit/Source/core/editing/EditingStrategy.cpp

+++ b/third_party/WebKit/Source/core/editing/EditingStrategy.cpp

@@ -69,7 +69,7 @@ int EditingAlgorithm<Traversal>::lastOffsetForEditing(const Node* node)

template <typename Strategy>

Node* EditingAlgorithm<Strategy>::rootUserSelectAllForNode(Node* node)

{

- if (!node || !nodeIsUserSelectAll(node))

+ if (!node || usedValueOfUserSelect(*node) != SELECT_ALL)

return nullptr;

Node* parent = Strategy::parent(*node);

if (!parent)

@@ -81,7 +81,7 @@ Node* EditingAlgorithm<Strategy>::rootUserSelectAllForNode(Node* node)

parent = Strategy::parent(*parent);

continue;

}

- if (!nodeIsUserSelectAll(parent))

+ if (usedValueOfUserSelect(*parent) != SELECT_ALL)

break;

candidateRoot = parent;

parent = Strategy::parent(*candidateRoot);