third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp - Issue 2151803002: Drop unnecessary finalization of NavigatorShare::ShareClientImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp

Issue 2151803002: Drop unnecessary finalization of NavigatorShare::ShareClientImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp

diff --git a/third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp b/third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp

index 74441a79cce43637e1dfabb9405792236fee5621..cf1aa86a3de6612a5e7795e03f9001dc09dba9cb 100644

--- a/third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp

+++ b/third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp

@@ -15,7 +15,7 @@

namespace blink {

-class NavigatorShare::ShareClientImpl : public GarbageCollectedFinalized<ShareClientImpl> {

+class NavigatorShare::ShareClientImpl final : public GarbageCollected<ShareClientImpl> {

public:

ShareClientImpl(NavigatorShare*, ScriptPromiseResolver*);

« no previous file with comments | « no previous file | no next file » | no next file with comments »