components/policy/core/browser/configuration_policy_handler.h - Issue 2151793002: Add base::Value::GetTypeName().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/browser/configuration_policy_handler.h

Issue 2151793002: Add base::Value::GetTypeName(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments, fix build Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/policy/core/browser/configuration_policy_handler.h

diff --git a/components/policy/core/browser/configuration_policy_handler.h b/components/policy/core/browser/configuration_policy_handler.h

index bad90b6b1a4800efbfeca60d331dad41ff5c93ec..2853ce8fca80c6e75ae8a0ad9437fbb73463e427 100644

--- a/components/policy/core/browser/configuration_policy_handler.h

+++ b/components/policy/core/browser/configuration_policy_handler.h

@@ -36,6 +36,7 @@ struct POLICY_EXPORT PolicyToPreferenceMapEntry {

// their corresponding preferences, and to check whether the policies are valid.

class POLICY_EXPORT ConfigurationPolicyHandler {

public:

+ // TODO(thestig): Replace with base::Value::GetTypeName().

static std::string ValueTypeToString(base::Value::Type type);

ConfigurationPolicyHandler();