Add base::Value::GetTypeName().

components/policy/core/browser/configuration_policy_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/policy/core/browser/configuration_policy_handler.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <utility>
@@ skipping 10 matching lines @@
 #include "components/policy/core/common/policy_map.h"
 #include "components/prefs/pref_value_map.h"
 #include "grit/components_strings.h"
 #include "url/gurl.h"
 
 namespace policy {
 
 // ConfigurationPolicyHandler implementation -----------------------------------
 
 // static
 std::string ConfigurationPolicyHandler::ValueTypeToString(

[pneubeck (no reviews), 2016/07/14 18:51:37]

maybe inline and remove this function?

[Lei Zhang, 2016/07/15 01:27:18]

It has a lot of callers. Added a TODO to make another pass.

     base::Value::Type type) {
-  static const char* strings[] = {
-    "null",
-    "boolean",
-    "integer",
-    "double",
-    "string",
-    "binary",
-    "dictionary",
-    "list"
-  };
-  CHECK(static_cast<size_t>(type) < arraysize(strings));
-  return std::string(strings[type]);
+  return std::string(base::Value::GetTypeName(type));
 }
 
 ConfigurationPolicyHandler::ConfigurationPolicyHandler() {
 }
 
 ConfigurationPolicyHandler::~ConfigurationPolicyHandler() {
 }
 
 void ConfigurationPolicyHandler::PrepareForDisplaying(
     PolicyMap* policies) const {}
@@ skipping 431 matching lines @@
     }
   }
 }
 void LegacyPoliciesDeprecatingPolicyHandler::ApplyPolicySettings(
     const policy::PolicyMap& /* policies */,
     PrefValueMap* /* prefs */) {
   NOTREACHED();
 }
 
 }  // namespace policy