Avoid jumping to the runtime for ForInFilter

[fullcodegen] [crankshaft] Avoid jumping to the runtime for ForInFilter

Use the ForInFilterStub directly. Hence we will only jump to the runtime for
special receivers (instance_type <= LAST_SPECIAL_RECEIVER_TYPE) and for
converting element indices which are not in the string cache.

BUG=

Committed: https://crrev.com/4b59bf53139f7c7a2c9b105d90f1bbd4c0c0150e
Cr-Commit-Position: refs/heads/master@{#37934}

[Camillo Bruni, 2016-07-18 12:53:07]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 12:53:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 13:02:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 13:02:18]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)

[Camillo Bruni, 2016-07-18 13:35:09]

cbruni@chromium.org changed reviewers:
+ ishell@chromium.org

[Camillo Bruni, 2016-07-18 13:35:10]

PTAL

[Camillo Bruni, 2016-07-19 13:13:59]

Description was changed from

==========
Avoid jumping to the runtime for ForInFilter

Use the HasPropertyStub and the ToNameStub directly. Hence we will only
jump to the runtime for JSProxy receivers and for converting element indices
which are not in the cache.

BUG=
==========

to

==========
[fullcodegen] [crankshaft] Avoid jumping to the runtime for ForInFilter

Use the HasPropertyStub and the ToNameStub directly. Hence we will only
jump to the runtime for JSProxy receivers and for converting element indices
which are not in the cache.

BUG=
==========

[Camillo Bruni, 2016-07-19 13:16:45]

Description was changed from

==========
[fullcodegen] [crankshaft] Avoid jumping to the runtime for ForInFilter

Use the HasPropertyStub and the ToNameStub directly. Hence we will only
jump to the runtime for JSProxy receivers and for converting element indices
which are not in the cache.

BUG=
==========

to

==========
[fullcodegen] [crankshaft] Avoid jumping to the runtime for ForInFilter

Use the ForInFilterStub directly. Hence we will only jump to the runtime for 
special receivers (instance_type <= LAST_SPECIAL_RECEIVER_TYPE) and for 
converting element indices which are not in the string cache.

BUG=
==========

[Camillo Bruni, 2016-07-19 13:19:28]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 13:19:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 13:23:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 13:23:46]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/9293)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)

[Camillo Bruni, 2016-07-19 13:32:00]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 13:32:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 13:39:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 13:39:42]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[Camillo Bruni, 2016-07-19 14:42:53]

cbruni@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Camillo Bruni, 2016-07-19 14:42:53]

mstarzinger@ PTAL turbofan code
ishell@ PTAL the rest

[Camillo Bruni, 2016-07-19 14:46:38]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 14:46:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Starzinger, 2016-07-19 15:06:02]

LGTM.

https://codereview.chromium.org/2151773002/diff/140001/src/code-stubs.cc
File src/code-stubs.cc (right):

https://codereview.chromium.org/2151773002/diff/140001/src/code-stubs.cc#newc...
src/code-stubs.cc:4303: // static
nit: The "static" comment no longer applies.

https://codereview.chromium.org/2151773002/diff/140001/src/code-stubs.cc#newc...
src/code-stubs.cc:4371: // stati c
nit: s/stati c/static/

[commit-bot: I haz the power, 2016-07-19 15:15:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 15:15:26]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng_trigg...)

[Igor Sheludko, 2016-07-20 11:06:51]

Looks good. Please add mips ports as well.

https://codereview.chromium.org/2151773002/diff/140001/src/full-codegen/arm64...
File src/full-codegen/arm64/full-codegen-arm64.cc (right):

https://codereview.chromium.org/2151773002/diff/140001/src/full-codegen/arm64...
src/full-codegen/arm64/full-codegen-arm64.cc:1106: RestoreContext();
Move RestoreContext() up and you can still use JumpIfRoot thing.

https://codereview.chromium.org/2151773002/diff/140001/src/full-codegen/arm64...
src/full-codegen/arm64/full-codegen-arm64.cc:1115: __ Bind(&update_each);
Nice :)

https://codereview.chromium.org/2151773002/diff/140001/src/full-codegen/x64/f...
File src/full-codegen/x64/full-codegen-x64.cc (right):

https://codereview.chromium.org/2151773002/diff/140001/src/full-codegen/x64/f...
src/full-codegen/x64/full-codegen-x64.cc:986: 
Spurious change?

https://codereview.chromium.org/2151773002/diff/140001/src/full-codegen/x64/f...
src/full-codegen/x64/full-codegen-x64.cc:1070: RestoreContext();
I would prefer to see the RestoreContext() call right after the CallStub (here
and in other ports). I guess if we bailout here then the context will already be
correct. Right?

[Camillo Bruni, 2016-07-20 12:42:41]

cbruni@chromium.org changed reviewers:
+ jarin@chromium.org

[Camillo Bruni, 2016-07-20 12:42:42]

jarin@ PTAL crankshaft/*
ishell@ PTAL again

https://codereview.chromium.org/2151773002/diff/140001/src/full-codegen/arm64...
File src/full-codegen/arm64/full-codegen-arm64.cc (right):

https://codereview.chromium.org/2151773002/diff/140001/src/full-codegen/arm64...
src/full-codegen/arm64/full-codegen-arm64.cc:1106: RestoreContext();
On 2016/07/20 at 11:06:51, Igor Sheludko wrote:
> Move RestoreContext() up and you can still use JumpIfRoot thing.

ah right, let's do that.

https://codereview.chromium.org/2151773002/diff/140001/src/full-codegen/x64/f...
File src/full-codegen/x64/full-codegen-x64.cc (right):

https://codereview.chromium.org/2151773002/diff/140001/src/full-codegen/x64/f...
src/full-codegen/x64/full-codegen-x64.cc:1070: RestoreContext();
On 2016/07/20 at 11:06:51, Igor Sheludko wrote:
> I would prefer to see the RestoreContext() call right after the CallStub (here
and in other ports). I guess if we bailout here then the context will already be
correct. Right?

right, changed.

[Camillo Bruni, 2016-07-20 13:09:07]

v8-ports FYI

[Jarin, 2016-07-20 13:12:19]

crankshaft part lgtm.

[Igor Sheludko, 2016-07-20 14:22:02]

lgtm with a nit:

https://codereview.chromium.org/2151773002/diff/180001/src/full-codegen/mips/...
File src/full-codegen/mips/full-codegen-mips.cc (right):

https://codereview.chromium.org/2151773002/diff/180001/src/full-codegen/mips/...
src/full-codegen/mips/full-codegen-mips.cc:1107: __ mov(a0, result_register());
Maybe put the mov instruction before the comment?

https://codereview.chromium.org/2151773002/diff/180001/src/full-codegen/mips6...
File src/full-codegen/mips64/full-codegen-mips64.cc (right):

https://codereview.chromium.org/2151773002/diff/180001/src/full-codegen/mips6...
src/full-codegen/mips64/full-codegen-mips64.cc:1108: __ mov(a0,
result_register());
Same here.

[Camillo Bruni, 2016-07-20 16:17:13]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2016-07-20 16:17:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, ishell@chromium.org, jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2151773002/#ps200001
(title: "addressing nits (moving instruction)")

[commit-bot: I haz the power, 2016-07-20 16:17:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 16:51:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 16:51:41]

Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng_trigg...)

[Camillo Bruni, 2016-07-21 09:03:54]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2016-07-21 09:03:54]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org,
jarin@chromium.org, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2151773002/#ps220001
(title: "remove double label")

[commit-bot: I haz the power, 2016-07-21 09:04:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 09:33:32]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2016-07-21 09:34:18]

Description was changed from

==========
[fullcodegen] [crankshaft] Avoid jumping to the runtime for ForInFilter

Use the ForInFilterStub directly. Hence we will only jump to the runtime for 
special receivers (instance_type <= LAST_SPECIAL_RECEIVER_TYPE) and for 
converting element indices which are not in the string cache.

BUG=
==========

to

==========
[fullcodegen] [crankshaft] Avoid jumping to the runtime for ForInFilter

Use the ForInFilterStub directly. Hence we will only jump to the runtime for
special receivers (instance_type <= LAST_SPECIAL_RECEIVER_TYPE) and for
converting element indices which are not in the string cache.

BUG=

Committed: https://crrev.com/4b59bf53139f7c7a2c9b105d90f1bbd4c0c0150e
Cr-Commit-Position: refs/heads/master@{#37934}
==========

[commit-bot: I haz the power, 2016-07-21 09:34:20]

Patchset 12 (id:??) landed as
https://crrev.com/4b59bf53139f7c7a2c9b105d90f1bbd4c0c0150e
Cr-Commit-Position: refs/heads/master@{#37934}