Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2151763003: In ChromeVox Next, create a text edit handler on "LoadComplete" if there is already a focused text … (Closed)

Created:
4 years, 5 months ago by Krzysztof Olczyk
Modified:
4 years, 5 months ago
CC:
aboxhall+watch_chromium.org, arv+watch_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, nektar+watch_chromium.org, oshima+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In ChromeVox Next, create a text edit handler on "LoadComplete" if there is already a focused text field in order not to miss the initial value change on such. BUG=628110 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/fff24ebf46beb620a5ce2400607cc249124773ec Cr-Commit-Position: refs/heads/master@{#405704}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Krzysztof Olczyk
Hi dmazzoni, nektar, could you please take a look at this small change?
4 years, 5 months ago (2016-07-14 08:31:10 UTC) #3
David Tseng
lgtm
4 years, 5 months ago (2016-07-14 20:58:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151763003/1
4 years, 5 months ago (2016-07-15 05:22:58 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 05:50:06 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 05:51:42 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fff24ebf46beb620a5ce2400607cc249124773ec
Cr-Commit-Position: refs/heads/master@{#405704}

Powered by Google App Engine
This is Rietveld 408576698