Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issue 2151753002: X87: [turbofan] Support subtraction displacements in BaseWithIndexAndDisplacementMatcher. (Closed)

Created:
4 years, 5 months ago by zhengxing.li
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Support subtraction displacements in BaseWithIndexAndDisplacementMatcher. port 574f6fe127fac2a22c4c909177bf0f3c30085bb0 (r37701) original commit message: Previously, the following schedule fragment: 1: Parameter[0](0) 2: Parameter[1](0) 7: Int32Constant[1] 8: Int32Sub(2, 7) 9: Load[kRepTagged|kTypeAny](1, 8) would generate the following code (on ia32): mov eax,[ebp+0x8] mov ecx,[ebp+0xc] sub eax,0x1 mov eax,[eax+ecx*1] Now it generates: mov eax,[ebp+0x8] mov ecx,[ebp+0xc] mov eax,[eax+ecx*1-1] Similar pattern matching also now works on x64. BUG= Committed: https://crrev.com/a71ebb88292403bc6c7d3866c5c9702f45278e4c Cr-Commit-Position: refs/heads/master@{#37738}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M src/compiler/x87/instruction-selector-x87.cc View 6 chunks +16 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 5 months ago (2016-07-14 02:23:25 UTC) #2
Weiliang
lgtm
4 years, 5 months ago (2016-07-14 02:31:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151753002/1
4 years, 5 months ago (2016-07-14 02:44:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 03:06:15 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 03:06:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a71ebb88292403bc6c7d3866c5c9702f45278e4c
Cr-Commit-Position: refs/heads/master@{#37738}

Powered by Google App Engine
This is Rietveld 408576698