Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 215173003: Remove support for custom pseudo elements. (Closed)

Created:
6 years, 9 months ago by dglazkov
Modified:
6 years, 9 months ago
Reviewers:
hayato, esprehn, tasak
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, rune+blink, watchdog-blink-watchlist_google.com, Inactive, rwlbuis
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -360 lines) Patch
M LayoutTests/fast/dom/shadow/custom-pseudo-in-selector-api.html View 1 chunk +0 lines, -14 lines 0 comments Download
M LayoutTests/fast/dom/shadow/custom-pseudo-in-selector-api-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/fast/dom/shadow/pseudo-attribute.html View 1 chunk +0 lines, -35 lines 0 comments Download
D LayoutTests/fast/dom/shadow/pseudo-attribute-dynamic.html View 1 chunk +0 lines, -37 lines 0 comments Download
D LayoutTests/fast/dom/shadow/pseudo-attribute-dynamic-expected.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/dom/shadow/pseudo-attribute-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/dom/shadow/pseudo-attribute-rendering.html View 1 chunk +0 lines, -34 lines 0 comments Download
D LayoutTests/fast/dom/shadow/pseudo-attribute-rendering-expected.html View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/dom/shadow/shadow-nested-pseudo-id.html View 1 chunk +0 lines, -51 lines 0 comments Download
D LayoutTests/fast/dom/shadow/shadow-nested-pseudo-id-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fast/dom/shadow/shadow-pseudo-id.html View 1 chunk +0 lines, -48 lines 0 comments Download
D LayoutTests/fast/dom/shadow/shadow-pseudo-id-expected.html View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/dom/shadow/styling-pseudo-attribute.html View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/fast/dom/shadow/styling-pseudo-attribute-expected.html View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/dom/shadow/styling-pseudo-attribute-in-shadow.html View 1 chunk +0 lines, -28 lines 0 comments Download
D LayoutTests/fast/dom/shadow/styling-pseudo-attribute-in-shadow-expected.html View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/css/CSSSelector.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/SelectorChecker.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/dom/Element.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/Element.cpp View 2 chunks +6 lines, -3 lines 0 comments Download
M Source/core/dom/Element.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
dglazkov
I figured I'd join the party :)
6 years, 9 months ago (2014-03-27 18:55:51 UTC) #1
esprehn
lgtm
6 years, 9 months ago (2014-03-27 20:03:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dglazkov@chromium.org/215173003/1
6 years, 9 months ago (2014-03-27 20:03:49 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 21:02:23 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-27 21:02:24 UTC) #5
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 9 months ago (2014-03-27 21:02:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dglazkov@chromium.org/215173003/1
6 years, 9 months ago (2014-03-27 21:02:55 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 22:32:50 UTC) #8
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-27 22:32:50 UTC) #9
dglazkov
The CQ bit was checked by dglazkov@chromium.org
6 years, 9 months ago (2014-03-27 22:35:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dglazkov@chromium.org/215173003/1
6 years, 9 months ago (2014-03-27 22:37:18 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 22:38:08 UTC) #12
Message was sent while issue was closed. 
Change committed as 170210

Powered by Google App Engine
This is Rietveld 408576698