Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2151723002:
Mark several layout tests as flaky on all platforms due to incorrect scrollbars. (Closed)
DescriptionMark several layout tests as flaky on all platforms due to incorrect scrollbars.
BUG=627798
NOTRY=true
TBR=wangxianzhu@chromium.org
Committed: https://crrev.com/87a98e4bdb72d8dd75c89d1c068f26516da0ef6b
Cr-Commit-Position: refs/heads/master@{#405367}
Patch Set 1 #Patch Set 2 : Mark as flaky on all platforms #Patch Set 3 : Make the other five tests flaky on other platforms too #Patch Set 4 : Resolve conflict #Messages
Total messages: 25 (12 generated)
The CQ bit was checked by alexmos@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by wangxianzhu@chromium.org
Please mark it as flaky on all platforms. It's really flaky on all platforms: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=edi...
On 2016/07/13 23:50:05, Xianzhu wrote: > Please mark it as flaky on all platforms. It's really flaky on all platforms: > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=edi... Thanks, done. Does this look good?
On 2016/07/13 23:52:57, alexmos wrote: > On 2016/07/13 23:50:05, Xianzhu wrote: > > Please mark it as flaky on all platforms. It's really flaky on all platforms: > > > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=edi... > > Thanks, done. Does this look good? Can you also remove [ Win ] from the other 5 tests? Thanks.
Description was changed from ========== Mark */inline-spelling-markers-hidpi-composited.html as flaky on Windows. BUG=627798 NOTRY=true TBR=wangxianzhu@chromium.org ========== to ========== Mark several layout tests as flaky due to incorrect scrollbars. Add */inline-spelling-markers-hidpi-composited.html as flaky, and make the other affected tests flaky on all platforms. BUG=627798 NOTRY=true TBR=wangxianzhu@chromium.org ==========
Description was changed from ========== Mark several layout tests as flaky due to incorrect scrollbars. Add */inline-spelling-markers-hidpi-composited.html as flaky, and make the other affected tests flaky on all platforms. BUG=627798 NOTRY=true TBR=wangxianzhu@chromium.org ========== to ========== Mark several layout tests as flaky due to incorrect scrollbars. Add */inline-spelling-markers-hidpi-composited.html as flaky, and make the other affected tests flaky on all platforms. BUG=627798 NOTRY=true TBR=wangxianzhu@chromium.org ==========
On 2016/07/13 23:54:28, Xianzhu wrote: > On 2016/07/13 23:52:57, alexmos wrote: > > On 2016/07/13 23:50:05, Xianzhu wrote: > > > Please mark it as flaky on all platforms. It's really flaky on all > platforms: > > > > > > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=edi... > > > > Thanks, done. Does this look good? > > Can you also remove [ Win ] from the other 5 tests? Thanks. Done.
The CQ bit was checked by wangxianzhu@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Mark several layout tests as flaky due to incorrect scrollbars. Add */inline-spelling-markers-hidpi-composited.html as flaky, and make the other affected tests flaky on all platforms. BUG=627798 NOTRY=true TBR=wangxianzhu@chromium.org ========== to ========== Mark several layout tests as flaky on all platforms due to incorrect scrollbars. BUG=627798 NOTRY=true TBR=wangxianzhu@chromium.org ==========
Description was changed from ========== Mark several layout tests as flaky on all platforms due to incorrect scrollbars. BUG=627798 NOTRY=true TBR=wangxianzhu@chromium.org ========== to ========== Mark several layout tests as flaky on all platforms due to incorrect scrollbars. BUG=627798 NOTRY=true TBR=wangxianzhu@chromium.org ==========
Turns out https://codereview.chromium.org/2150523003/ already marked inline-spelling-markers-hidpi-composited.html as flaky, so this is now just making all these tests flaky for all platforms rather than just windows.
The CQ bit was checked by alexmos@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from wangxianzhu@chromium.org Link to the patchset: https://codereview.chromium.org/2151723002/#ps60001 (title: "Resolve conflict")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Mark several layout tests as flaky on all platforms due to incorrect scrollbars. BUG=627798 NOTRY=true TBR=wangxianzhu@chromium.org ========== to ========== Mark several layout tests as flaky on all platforms due to incorrect scrollbars. BUG=627798 NOTRY=true TBR=wangxianzhu@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Mark several layout tests as flaky on all platforms due to incorrect scrollbars. BUG=627798 NOTRY=true TBR=wangxianzhu@chromium.org ========== to ========== Mark several layout tests as flaky on all platforms due to incorrect scrollbars. BUG=627798 NOTRY=true TBR=wangxianzhu@chromium.org Committed: https://crrev.com/87a98e4bdb72d8dd75c89d1c068f26516da0ef6b Cr-Commit-Position: refs/heads/master@{#405367} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/87a98e4bdb72d8dd75c89d1c068f26516da0ef6b Cr-Commit-Position: refs/heads/master@{#405367} |
