Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4422)

Unified Diff: chrome/test/data/extensions/api_test/automation/tests/tabs/find.js

Issue 2151713002: Less strict checked state changes and introduce disabled state for content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: m Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/automation/tests/tabs/find.js
diff --git a/chrome/test/data/extensions/api_test/automation/tests/tabs/find.js b/chrome/test/data/extensions/api_test/automation/tests/tabs/find.js
index 07b1f618b8c9596eec1cc42ae92580b872999cf3..a686ded94d160632f761dc8967476f1392f0ecce 100644
--- a/chrome/test/data/extensions/api_test/automation/tests/tabs/find.js
+++ b/chrome/test/data/extensions/api_test/automation/tests/tabs/find.js
@@ -42,12 +42,13 @@ function initializeNodes(rootNode) {
okButton = anonGroup.firstChild;
assertEq(RoleType.button, okButton.role);
assertEq('Ok', okButton.name);
- assertFalse(StateType.enabled in okButton.state);
+ assertTrue(StateType.disabled in okButton.state);
+ assertTrue(okButton.state.disabled);
cancelButton = anonGroup.lastChild;
assertEq(RoleType.button, cancelButton.role);
assertEq('Cancel', cancelButton.name);
- assertTrue(StateType.enabled in cancelButton.state);
+ assertFalse(StateType.disabled in cancelButton.state);
}
var allTests = [
@@ -96,21 +97,21 @@ var allTests = [
// Find disabled buttons.
assertEq(okButton, rootNode.find({ role: RoleType.button,
- state: { enabled: false }}));
+ state: { disabled: true }}));
assertEq([okButton], rootNode.findAll({ role: RoleType.button,
- state: { enabled: false }}));
+ state: { disabled: true }}));
// Find disabled buttons within a portion of the tree.
assertEq(okButton, anonGroup.find({ role: RoleType.button,
- state: { enabled: false }}));
+ state: { disabled: true }}));
assertEq([okButton], anonGroup.findAll({ role: RoleType.button,
- state: { enabled: false }}));
+ state: { disabled: true }}));
// Find enabled buttons.
assertEq(cancelButton, rootNode.find({ role: RoleType.button,
- state: { enabled: true }}));
+ state: { disabled: false }}));
assertEq([cancelButton], rootNode.findAll({ role: RoleType.button,
- state: { enabled: true }}));
+ state: { disabled: false }}));
chrome.test.succeed();
},

Powered by Google App Engine
This is Rietveld 408576698