Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2151693009: Preserve referrer across CORS-enabled redirects (Closed)

Created:
4 years, 5 months ago by estark
Modified:
4 years, 5 months ago
CC:
blink-reviews, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, loading-reviews_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Preserve referrer across CORS-enabled redirects When following a CORS-enabled redirect in DocumentThreadableLoader, use the previous leg's referrer as the starting point instead of the document's URL. This matches the Referrer Policy spec and ensures that information is never added to the referrer when following a redirect. (In other words, if the referrer is stripped in one leg of a request, it will not be re-created in a subsequent leg.) BUG=628457 Committed: https://crrev.com/8aa9abc54f9bfedcce035846a2cc898d5b252957 Cr-Commit-Position: refs/heads/master@{#406289}

Patch Set 1 #

Patch Set 2 : add layout test #

Patch Set 3 : add comment #

Messages

Total messages: 11 (5 generated)
estark
jochen: WDYT? This makes it so that following a CORS redirect matches what the net ...
4 years, 5 months ago (2016-07-18 22:11:24 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-07-19 12:21:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151693009/40001
4 years, 5 months ago (2016-07-19 15:55:23 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-19 16:13:46 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 16:13:49 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 16:16:46 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8aa9abc54f9bfedcce035846a2cc898d5b252957
Cr-Commit-Position: refs/heads/master@{#406289}

Powered by Google App Engine
This is Rietveld 408576698