Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2151693008: [ios] Use -[WKWebView serverTrust] instead of certificateChain on iOS 10. (Closed)

Created:
4 years, 5 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 4 months ago
Reviewers:
davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Use -[WKWebView serverTrust] instead of certificateChain on iOS 10. |certificateChain| WKWebView method is deprecated on iOS 10 and |serverTrust| must be used instead. BUG=628699 Committed: https://crrev.com/049741269398bcc7c2b9aaf309d175d1fac9d90b Cr-Commit-Position: refs/heads/master@{#407812}

Patch Set 1 #

Patch Set 2 : Self review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -57 lines) Patch
M ios/web/net/crw_ssl_status_updater.h View 3 chunks +7 lines, -4 lines 0 comments Download
M ios/web/net/crw_ssl_status_updater.mm View 1 9 chunks +30 lines, -29 lines 0 comments Download
M ios/web/net/crw_ssl_status_updater_unittest.mm View 12 chunks +19 lines, -17 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 2 chunks +16 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Eugene But (OOO till 7-30)
4 years, 5 months ago (2016-07-15 18:43:47 UTC) #2
davidben
(I'm at IETF until the week after next, so you probably want to find a ...
4 years, 5 months ago (2016-07-15 18:45:07 UTC) #3
Eugene But (OOO till 7-30)
On 2016/07/15 18:45:07, davidben (OOO until 7-25) wrote: > (I'm at IETF until the week ...
4 years, 5 months ago (2016-07-15 18:47:19 UTC) #4
davidben
lgtm
4 years, 4 months ago (2016-07-26 14:57:10 UTC) #5
Eugene But (OOO till 7-30)
Thanks!
4 years, 4 months ago (2016-07-26 15:19:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151693008/20001
4 years, 4 months ago (2016-07-26 15:20:17 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-26 15:50:32 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 15:53:21 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/049741269398bcc7c2b9aaf309d175d1fac9d90b
Cr-Commit-Position: refs/heads/master@{#407812}

Powered by Google App Engine
This is Rietveld 408576698